Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork PR upload should retry after GH rate limit when using tokenless upload. #441

Closed
kaovilai opened this issue May 9, 2024 · 1 comment

Comments

@kaovilai
Copy link

kaovilai commented May 9, 2024

The cli should wait and retry when using tokenless in fork PRs.

Code that logs when failing to upload

logger.info("The PR is happening in a forked repo. Using tokenless upload.")

Example: vmware-tanzu/velero#7787

@thomasrockhu-codecov
Copy link
Contributor

@kaovilai I believe this does try to retry after about 10 seconds. We cannot block CI on this rate limit as it can push CI builds into the hours of time.

More importantly, I think the underlying issue should be resolved with this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants