[v2 seat allocation iter 1] Allow onboarding for private repos to be viewed for inactive users #2794
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2794 +/- ##
=======================================
+ Coverage 98.47 98.48 +0.01
=======================================
Files 868 868
Lines 12713 12723 +10
Branches 3342 3413 +71
=======================================
+ Hits 12519 12529 +10
Misses 190 190
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2794 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 868 868
Lines 12713 12723 +10
Branches 3400 3418 +18
=======================================
+ Hits 12519 12529 +10
Misses 190 190
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2794 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 868 868
Lines 12713 12723 +10
Branches 3400 3413 +13
=======================================
+ Hits 12519 12529 +10
Misses 190 190
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #2794 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 873 873
Lines 12632 12633 +1
Branches 3314 3316 +2
=======================================
+ Hits 12434 12435 +1
Misses 192 192
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 18 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 18 bytes ⬆️
|
rohitvinnakota-codecov
changed the title
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
…odecov/gazebo into rvinnakota/private-repo-iter-1
rohitvinnakota-codecov
changed the title
src/pages/RepoPage/RepoPageTabs.tsx
Outdated
| tabs.push({ pageName: 'componentsTab' }) | ||
| } | ||
|
|
||
| if (repoOverview?.bundleAnalysisEnabled || repoOverview?.coverageEnabled) { | ||
| if ( | ||
| repoOverview?.bundleAnalysisEnabled || |
There was a problem hiding this comment.
we gotta check for the activation here as well
| if (!refetchEnabled && !isRepoActivated) { | ||
| setRefetchEnabled(true) | ||
| } | ||
| if (!repoData?.repository) return <NotFound /> | ||
| if (!repoData) return <NotFound /> |
There was a problem hiding this comment.
We could get a null repository response if the owner is not activated but we don't want to show a NotFound in that case.
This PR addresses follow-ups to codecov/engineering-team#1253
Please note that changes here are reliant on this API PR.
With this change, we should be able to
See iteration 1 here for more information.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.