Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to npmjs.com #474

Closed
remcohaszing opened this issue Oct 27, 2021 · 8 comments
Closed

Publish to npmjs.com #474

remcohaszing opened this issue Oct 27, 2021 · 8 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@remcohaszing
Copy link

Is your feature request related to a problem? Please describe.

Although it’s understandable codecov can’t maintain packages for each programming language, it was convenient for end users.

Describe the solution you'd like

Since this project uses NodeJS / npm, it would be pretty low effort to publish it to npmjs.com. This way at least the JavaScript community can use npm to download it.

Describe alternatives you've considered

Don’t publish to npmjs.com and close this issue 🤷

Additional context

N/A

@drazisil-codecov
Copy link
Contributor

@remcohaszing

The choice to publish to npm and other package managers is one we are discussing internally , but it's taking a back seat to higher priority blockers.

Personally , I'm against publishing it because I want to reduce the ease of integration into other tools that users may expect us to support. I am aware that goes against the spirit of open source. That being said, I agree that publishing it would make it very convenient in certain cases.

@drazisil-codecov drazisil-codecov added the enhancement New feature or request label Oct 27, 2021
@remcohaszing
Copy link
Author

The main reason I’m interested in this, is for GitLab CI.

GitLab CI jobs (typically) run inside a Docker container. To use the new Codecov uploader, we would either have to wget Codecov for each pipeline or build a custom Docker image to combine NodeJS and Codecov.

Alternatively Codecov could support GitLab status checks, but that’s out of scope for this issue.

@drazisil-codecov
Copy link
Contributor

Alternatively Codecov could support GitLab status checks, but that’s out of scope for this issue.

We do. It's something that we broke for a while this year, but it was fixed a week or so ago. Are you not seeing them?

@drazisil-codecov
Copy link
Contributor

GitLab CI jobs (typically) run inside a Docker container. To use the new Codecov uploader, we would either have to wget Codecov for each pipeline or build a custom Docker image to combine NodeJS and Codecov.

That is the recommended way to use it, per https://docs.codecov.com/docs/codecov-uploader#using-the-uploader-with-codecovio-cloud, as well as how we use it ourselves.

Am I misunderstanding your use case?

@drazisil-codecov drazisil-codecov added the question Further information is requested label Nov 9, 2021
@dmull-amtote
Copy link

I need to build uploader from source due to the binary not working (exit code 4, no output) in my CI environment and I don't know why. The binary works in the same container locally.

Being able to pull it from npm would have made my deploy simpler.

@drazisil-codecov
Copy link
Contributor

I need to build uploader from source due to the binary not working (exit code 4, no output) in my CI environment and I don't know why. The binary works in the same container locally.

Being able to pull it from npm would have made my deploy simpler.

@dmull-amtote Is #475 the cause of your issue with the exit code?

@dmull-amtote
Copy link

dmull-amtote commented Feb 22, 2022

@drazisil-codecov

Is #475 the cause of your issue with the exit code?

Ohhh. Yea. It is! I missed that. Thanks.

@merrywhether
Copy link

Publishing to npm would also gives users "free" integrity checking via the various lockfiles when they do a frozen install in CI.

The protection from integration expectations is an interesting perspective I hadn't thought of before, but I can totally understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants