Generate PDF #405
Generate PDF #405
Conversation
sree-cfa
force-pushed
the
generate-pdf
branch
from
1953c4c
to
0ea0095
Compare
sree-cfa
force-pushed
the
generate-pdf
branch
from
2636609
to
7fa6a7f
Compare
sree-cfa
force-pushed
the
generate-pdf
branch
from
7fa6a7f
to
fad42ab
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/test/java/org/ladocuploader/app/preparers/MaritalStatusPreparerTest.java
Fixed
Show fixed
Hide fixed
src/test/java/org/ladocuploader/app/preparers/PersonalSituationsPreparerTest.java
Fixed
Show fixed
Hide fixed
src/main/java/org/ladocuploader/app/preparers/PersonalSituationsPreparer.java
Fixed
Show fixed
Hide fixed
sree-cfa
force-pushed
the
generate-pdf
branch
from
593845a
to
51ddd5e
Compare
src/main/java/org/ladocuploader/app/preparers/HouseholdDetailsPreparer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ladocuploader/app/preparers/PersonalSituationsPreparer.java
Show resolved
Hide resolved
src/main/java/org/ladocuploader/app/utils/SubmissionUtilities.java
Outdated
Show resolved
Hide resolved
| @@ -5,10 +5,11 @@ | |||
| <a class="text--small font-white spacing-below-15" target="_blank" rel="noopener noreferrer" href="/privacy" | |||
| th:text="#{footer.privacy}"></a> | |||
| <th:block th:if="${#arrays.contains(@environment.getActiveProfiles(), 'demo') || #arrays.contains(@environment.getActiveProfiles(), 'dev')}"> | |||
| <br>Download links (demo-only): | |||
| <br/>Download links (demo-only): | |||
There was a problem hiding this comment.
Leaving this comment here, though the scope/work of this is outside this PR.
We should move this to another fragment that only gets included in the "dev" environment. Or "demo".
The risks of sharing private data are REALLY high if we forget to take this out - so it might be good to protect against that right now.
|
In testing I noticed that the disability field is not getting populated: 
Also noticing that text doesn't really fit in some of the fields. I know that's not due to this PR, but definitely something we need to fix somehow. 
|
Yeah def - roshan will be doing PDF acceptance testing when he gets back so just leaving it until then 🤷 |
|
@sree-cfa I think we should fix the part where the disability checkbox is not getting checked - it's the first of the two images above and maybe was missed. |
|
@bseeger oh yeah agreed - that is fixed now. The sizing and display stuff can wait for roshan to review |
Adding demo-only link for generating pdf and basic mappings Filling in page A1 of pdf
sree-cfa
force-pushed
the
generate-pdf
branch
from
505e96b
to
cdf2d3f
Compare
This PR
Follow-up PR will include