generated from codeforamerica/form-flow-starter-app
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more pdf field mappings #465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sree-cfa
force-pushed
the
adding-pdf-fields
branch
from
December 20, 2023 01:35
b26ab0e
to
3bdb2ee
Compare
src/main/java/org/ladocuploader/app/preparers/HouseholdExpensesPreparer.java
Fixed
Show fixed
Hide fixed
src/main/java/org/ladocuploader/app/preparers/HouseholdExpensesPreparer.java
Fixed
Show fixed
Hide fixed
sree-cfa
force-pushed
the
adding-pdf-fields
branch
from
December 20, 2023 19:06
0588420
to
e2c18e1
Compare
sree-cfa
commented
Dec 21, 2023
@@ -163,8 +163,6 @@ public class LaDigitalAssister extends FlowInputs { | |||
|
|||
private String outOfStateBenefitsRecipients; | |||
|
|||
private String receivedOutOfStateBenefits; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean-up - this is a duplicate of the field above
sree-cfa
force-pushed
the
adding-pdf-fields
branch
from
December 21, 2023 17:47
915b673
to
6ff7702
Compare
analoo
reviewed
Dec 21, 2023
src/main/java/org/ladocuploader/app/preparers/HouseholdExpensesPreparer.java
Outdated
Show resolved
Hide resolved
Adding student expenses and clean up updating ssn pdf mapping Add pregnancy details Adding out of state benefits mapper Adding mappings for special situations where theres a list of names Adding income mapper
sree-cfa
force-pushed
the
adding-pdf-fields
branch
from
December 21, 2023 22:36
6ff7702
to
df21753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that Roshan will QA the contents of the pdf itself - please disregard formatting related to font/spacing etc
In this PR: