Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary Commented Code #45

Open
ProsperousHeart opened this issue May 27, 2023 · 0 comments
Open

Remove Unnecessary Commented Code #45

ProsperousHeart opened this issue May 27, 2023 · 0 comments
Assignees
Labels
documentation Update to documentation enhancement Not a requirement - enhances or improves project

Comments

@ProsperousHeart
Copy link
Member

ProsperousHeart commented May 27, 2023

          Looks good to me. I'm curious about App.js though, there's a lot of commented code. It looks like a lot of it is for scrolling animations? I'm guessing it'll either be implemented or removed in the future.

Originally posted by @RobinHerzig in #42 (review)

==============

          Yea - this was stuff I was working on to make the nav bar work in my other site.
          - A lot of it is commented console logging to confirm what I was seeing.
          - Some is code I was able to pull out and put elsewhere.
          
          I'll create an issue to clean this up - at least for the code I know can be removed. (Minus the create-react-app code ... at least until we have the volunteer group meeting to show where it once was)
          
          Thanks @RobinHerzig

Originally posted by @ProsperousHeart in #42 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Update to documentation enhancement Not a requirement - enhances or improves project
Projects
Status: Backlog
Development

No branches or pull requests

1 participant