Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change user list to preserve search string & paging #871

Open
seankwilliams opened this issue Nov 10, 2023 · 2 comments
Open

Change user list to preserve search string & paging #871

seankwilliams opened this issue Nov 10, 2023 · 2 comments

Comments

@seankwilliams
Copy link
Collaborator

When using the page at /user/search, if you go to the second page or use the search term, and then go back, the paging and search filters is not preserved. You are back to page one, without a search string.

Ideally this page should preserve everything when you go back:

  • paging
  • Whether All, Active, or Inactive is preserved
  • The value of the search box
  • Scroll position

However, recognizing that the scroll position can be challenging to implement, if we could just get the paging, filters and search string preserved that would be a huge win, and we can make a separate issue to resolve the scroll position.

@kmid5280
Copy link
Contributor

@seankwilliams I'm attempting to duplicate this error. It looks like the "previous" and "next" buttons under the search results work as intended.

When you say "go to the second page," do you mean clicking on one of the search results? Is this an issue that mainly happens when navigating away from the search page entirely?

@seankwilliams
Copy link
Collaborator Author

@kmid5280 You're right, I misphrased things in the original description. This is a problem when you go click on a row to go into a user page and then try to go back to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants