Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bash files automatically #1691

Closed
worksofliam opened this issue Dec 5, 2023 · 3 comments · Fixed by #1695
Closed

Make bash files automatically #1691

worksofliam opened this issue Dec 5, 2023 · 3 comments · Fixed by #1695
Assignees
Milestone

Comments

@worksofliam
Copy link
Contributor

A majority of our users don't even have .bash_profile or .bashrc setup.

I think if the user has bash as their default shell, and those files don't exist, we should create them with the following content:

# Generated by Code for IBM i
export PATH=/QOpenSys/pkgs/bin/:$PATH

@codefori/core @ThePrez What do you think?

@worksofliam worksofliam added this to the 3.0.0 milestone Dec 5, 2023
@ThePrez
Copy link
Collaborator

ThePrez commented Dec 5, 2023

That could potentially break people that have valuable things in .profile if I recall correctly. Doing env setup seems like an easy task but is way more complicated than it should be 😞

@worksofliam
Copy link
Contributor Author

@ThePrez If that is the case, then maybe we only create those files if .profile doesn't exist also.

@edmundreinhardt
Copy link
Collaborator

I think we have something analogous, when a connection is connected we check for other things and prompt the user. It would be a good time to check if pkgs/bin is in the path, and if not, offer to append it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants