Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no example of tolerations json format (and it does not work whatever I try) #563

Open
brechtvalcke opened this issue Sep 25, 2020 · 1 comment

Comments

@brechtvalcke
Copy link

Hi I tried to install codefresh with tolerations but it gives me this error:
Error: can not parse tolerations: invalid character 'c' looking for beginning of value

Tried to run this command
codefresh runner init --kube-namespace codefresh --tolerations config/kubernetes/dependencies/codefresh/tolerations.json --kube-node-selector "cloud.google.com/gke-preemptible=true"

and I tried these 2 configurations in my tolerations json file:

[
    {
        "key": "preemptible",
        "value": "true",
        "effect": "NoSchedule"
    }
]

AND

{
    "tolerations": [
       {
          "key": "preemptible",
          "value": "true",
          "effect": "NoSchedule"
       }
    ]
 }

However I have never written tolerations as json before so I could be completely wrong here... (Yaml would be way more easy as everyone writes manifests in yaml instead of json)

What is the correct syntax for this?

Thank you very much in advance!

@beatgeek
Copy link

Running into a gap in the docs here too.
I want to install a runner with tolerations but not clear how this all get put together. And please support yaml inputs!
The cli states The Kubernetes tolerations as path to a JSON file prefixed with @ to be used by runner resources (default is no tolerations) (string) so I image it's codefresh runner init --tolerations path-to-file/@tolerations.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants