Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View data not being passed between each call? #1621

Closed
niteraven7 opened this issue Dec 20, 2018 · 2 comments
Closed

View data not being passed between each call? #1621

niteraven7 opened this issue Dec 20, 2018 · 2 comments

Comments

@niteraven7
Copy link

I updated from alpha3 to alpha4 and view data is no longer being passed from view to view. I have a partial template that echos notices, for example "echo $validation->listErrors()". It's being called from a view so I can reuse the code. The $validation variable is no longer being passed from view to view. Has something changed in alpha4? I cannot figure out where from the changelog.

FYI:
Config\View.php
public $saveData = true;

version: alpha4

@niteraven7
Copy link
Author

niteraven7 commented Dec 20, 2018

It looks like the view config file is not being loaded?

If I change System\View\View.php:
public function __construct {
$this->saveData = true;
}

It works. Does this have anything to do with all the path changes?

@lonnieezell
Copy link
Member

You're right - the config file wasn't being loaded due to a change in the Toolbar passing the wrong parameters to grab the view, which ended up not loading the view, and the view instance got cached with the wrong setting.

Fixed in latest push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants