Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable coveralls auto comment on pull request #382

Closed
samsonasik opened this issue Jan 20, 2017 · 3 comments
Closed

disable coveralls auto comment on pull request #382

samsonasik opened this issue Jan 20, 2017 · 3 comments

Comments

@samsonasik
Copy link
Member

I think coveralls auto comment should be disabled:

screen shot 2017-01-20 at 1 03 29 pm

As the coveralls status is represented in build summary checklist itself.

@lonnieezell
Copy link
Member

The one nice thing about having the comments on is that it makes a nice reminder for us or any contributors, to go write tests, which is a good thing. :)

I think I'd like to keep them in for now, and I know it might get a bit noisy, so we'll keep an eye on it. It could definitely become annoying. I think most of those times, though, will be when someone isn't testing locally, but is using Travis to do all of the heavy lifting for them. Again, though, will keep an eye on it and see how bothersome it becomes.

@samsonasik
Copy link
Member Author

Thank you, actually, the report itself is on the built summary on each commit pushed:
screen shot 2017-01-23 at 12 25 06 pm

@lonnieezell
Copy link
Member

I understand that, but I think that has a different impact then seeing it in the comment. In the summary at the bottom, it simply feels like it's saying, "You failed" when all it really means is coverage went down. I think seeing the comment has a more immediate impact to the person submitting the PR, while the summary is more for the person accepting the PR.

Don't worry, I'll likely get tired of it before too long, but want to live with it a little to make a final decision. :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants