Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: typo error when creating a model using php spark make:model #4525

Closed
reszko opened this issue Apr 7, 2021 · 1 comment
Closed

Bug: typo error when creating a model using php spark make:model #4525

reszko opened this issue Apr 7, 2021 · 1 comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@reszko
Copy link

reszko commented Apr 7, 2021

Describe the bug
The command line php spark make:model creates a Model File with the propertie $useSoftDelete in singular, when the correct way is in the plural, like this:

$useSoftDeletes

Because of this, that feature does not work when deleting records.

CodeIgniter 4 version
4.1.1

Expected behavior, and steps to reproduce if appropriate
$useSoftDeletes

Context

  • OS: [e.g. Windows 10]
  • Web server [e.g. 2.4.46]
  • PHP version [e.g. 7.3.21]
@reszko reszko added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 7, 2021
@samsonasik
Copy link
Member

It seems already fixed in latest develop #4319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samsonasik @reszko