Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Zip library from CI3 #505

Closed
lonnieezell opened this issue May 19, 2017 · 6 comments
Closed

Port Zip library from CI3 #505

lonnieezell opened this issue May 19, 2017 · 6 comments
Assignees
Milestone

Comments

@lonnieezell
Copy link
Member

No description provided.

@lonnieezell lonnieezell added the help wanted More help is needed for the proper resolution of an issue or pull request label May 19, 2017
@lonnieezell lonnieezell added this to the Pre-Alpha 2 milestone May 19, 2017
@otengkwame
Copy link

@lonnieezell How can i help

@lonnieezell
Copy link
Member Author

If you want to make a PR with a converted library from CI3, that would be great. You can find all of the information about our contributor guidelines and style requirements over here.

@jim-parry
Copy link
Contributor

I suggest an approach like the Encryption package ...
system/Compression/Compression
system/Compression/CompressorInterface
system/Compression/Handlers/BaseHandler
system/Compression/Handlers/ZipHandler
application/Config/Compression
system/Config/Services::compressor()

This would set us up nicely for adding other compressers, like gz or tar.
What do you think, @lonnieezell ?

@lonnieezell
Copy link
Member Author

Makes sense to me @jim-parry

@jim-parry jim-parry removed the help wanted More help is needed for the proper resolution of an issue or pull request label May 30, 2018
@jim-parry jim-parry self-assigned this May 30, 2018
@jim-parry
Copy link
Contributor

Given the lack of advancement, or indication of same, I will tackle this.

@jim-parry jim-parry changed the title Port Zip library from CI3 WIP Port Zip library from CI3 Aug 31, 2018
@jim-parry jim-parry changed the title WIP Port Zip library from CI3 Port Zip library from CI3 Sep 9, 2018
@jim-parry
Copy link
Contributor

Implementing the handler for PHP's built-in ZipArchive, it appears that that library does everything the CI3 one did. Closing this - we don't need to reinvent the wheel. Need to reference ZipArchive in the upgrading guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants