Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: remove _parent_name in BaseBuilder::objectToArray() #6412

Closed
kenjis opened this issue Aug 23, 2022 · 4 comments · Fixed by #6427
Closed

Dev: remove _parent_name in BaseBuilder::objectToArray() #6412

kenjis opened this issue Aug 23, 2022 · 4 comments · Fixed by #6427
Assignees
Labels

Comments

@kenjis
Copy link
Member

kenjis commented Aug 23, 2022

I would like to remove _parent_name in BaseBuilder::objectToArray().

// There are some built in keys we need to ignore for this conversion
if (! is_object($val) && ! is_array($val) && $key !== '_parent_name') {

Because it seems there is no place to use '_parent_name' in the code base.

@kenjis kenjis added the dev label Aug 23, 2022
@MGatner
Copy link
Member

MGatner commented Aug 23, 2022

I'm not even sure what this does 😅

@kenjis
Copy link
Member Author

kenjis commented Aug 23, 2022

I don't know either.

@iRedds
Copy link
Collaborator

iRedds commented Aug 25, 2022

It came from ci2 (I didn't find the 1.x version). Perhaps this is an internal solution from EllisLab.

@MGatner
Copy link
Member

MGatner commented Aug 25, 2022

Wow. That's some legacy!

Burn it with 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants