Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Point pre_system and post_system are different from the docs #8049

Closed
kenjis opened this issue Oct 16, 2023 · 4 comments · Fixed by #8055 or #8076
Closed

Event Point pre_system and post_system are different from the docs #8049

kenjis opened this issue Oct 16, 2023 · 4 comments · Fixed by #8055 or #8076
Labels
bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only

Comments

@kenjis
Copy link
Member

kenjis commented Oct 16, 2023

Are these bugs or not?

https://codeigniter4.github.io/CodeIgniter4/extending/events.html#event-points

  • pre_system Called very early during system execution. Only the benchmark and events class have been loaded at this point. No routing or other processes have happened.
  • post_system Called after the final rendered page is sent to the browser, at the end of system execution after the finalized data is sent to the browser.
@kenjis
Copy link
Member Author

kenjis commented Oct 16, 2023

Is the CI4 documentation just out of date?
http://codeigniter.com/userguide3/general/hooks.html#hook-points

Why are pre_controller, post_controller, display_override, and cache_override missing in CI4?

@MGatner
Copy link
Member

MGatner commented Oct 17, 2023

I think just inaccurate descriptions. I wouldn't change the current behavior.

@kenjis
Copy link
Member Author

kenjis commented Oct 18, 2023

Okay, I will fix as a bug in the docs.

@kenjis kenjis added documentation Pull requests for documentation only bug Verified issues on the current code behavior or pull requests that will fix them labels Oct 18, 2023
@kenjis
Copy link
Member Author

kenjis commented Oct 18, 2023

I sent a PR #8055.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only
Projects
None yet
2 participants