-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Database Collector display #5553
Refactor Database Collector display #5553
Conversation
This is not because of this PR, but I got JS error and when I click the Toolbar icon, it does not show up (remain closed).
|
Mine, too.
|
The bug comes from #5544. |
@paulbalandan I rebased this branch on my local. Two things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- line number needs different color
- the bottom line of back trace is not correct
1fa5c86
to
973ab18
Compare
Sorry, I didn't see these comments when I force pushed my new changes.
|
Okay, you changed the output, and it is acceptable. |
Another quirk of PHP, providing
|
2f23f70
to
1a52fbf
Compare
How about removing the first two lines?
|
Why? |
These lines are DBQuery event trigger and always the same. |
This looks good to me. Thanks everyone! Merging. |
Refactor Database Collector display
Description
Fixes #5539
Supersedes and closes #5543
Checklist: