From 4e0a9f43c23805ec9344c57dada1dfde5652fcd3 Mon Sep 17 00:00:00 2001 From: kenjis Date: Fri, 4 Feb 2022 11:16:59 +0900 Subject: [PATCH 1/2] config: remove out-of-dated migrations routes --- system/Config/Routes.php | 5 ----- 1 file changed, 5 deletions(-) diff --git a/system/Config/Routes.php b/system/Config/Routes.php index 15298ce6cf2a..0f16b675a8ad 100644 --- a/system/Config/Routes.php +++ b/system/Config/Routes.php @@ -19,10 +19,5 @@ * already loaded up and ready for us to use. */ -// Migrations -$routes->cli('migrations/(:segment)/(:segment)', '\CodeIgniter\Commands\MigrationsCommand::$1/$2'); -$routes->cli('migrations/(:segment)', '\CodeIgniter\Commands\MigrationsCommand::$1'); -$routes->cli('migrations', '\CodeIgniter\Commands\MigrationsCommand::index'); - // CLI Catchall - uses a _remap to call Commands $routes->cli('ci(:any)', '\CodeIgniter\CLI\CommandRunner::index/$1'); From 345e8cfcb96e52144129621ba0701971e6bcf96a Mon Sep 17 00:00:00 2001 From: kenjis Date: Fri, 4 Feb 2022 11:19:33 +0900 Subject: [PATCH 2/2] docs: remove out-of-dated explanation of Command --- contributing/internals.md | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/contributing/internals.md b/contributing/internals.md index 6ced5f56dc48..acba8d9fdbd8 100644 --- a/contributing/internals.md +++ b/contributing/internals.md @@ -122,17 +122,9 @@ scans and keep performance high. ## Command-Line Support -CodeIgniter has never been known for it's strong CLI support. However, +CodeIgniter has never been known for its strong CLI support. However, if your package could benefit from it, create a new file under -**system/Commands**. The class contained within is simply a controller -that is intended for CLI usage only. The `index()` method should provide -a list of available commands provided by that package. - -Routes must be added to **system/Config/Routes.php** using the `cli()` -method to ensure it is not accessible through the browser, but is -restricted to the CLI only. - -See the **MigrationsCommand** file for an example. +**system/Commands**. ## Documentation