Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Solution] Added non-passive event listener warning in Chrome #6735

Open
usersina opened this issue Jul 4, 2021 · 2 comments
Open

[Solution] Added non-passive event listener warning in Chrome #6735

usersina opened this issue Jul 4, 2021 · 2 comments

Comments

@usersina
Copy link

usersina commented Jul 4, 2021

This warning can simply be fixed, as of version 5.62.0 by changing the line 536 in codemirror/lib/codemirror.js

From

emitter.addEventListener(type, f, false);

To

emitter.addEventListener(type, f, {passive: false});
@marijnh
Copy link
Member

marijnh commented Jul 5, 2021

Will that not cause IE to set useCapture to true for the listener?

@cperotAxway
Copy link

would be great if it can be fixed message in console:

[Violation] Added non-passive event listener to a scroll-blocking event. Consider marking event handler as 'passive' to make the page more responsive. See

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants