Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell check fixing broken as of 6.28.0+ #1415

Closed
zefhemel opened this issue Jul 29, 2024 · 2 comments
Closed

Spell check fixing broken as of 6.28.0+ #1415

zefhemel opened this issue Jul 29, 2024 · 2 comments

Comments

@zefhemel
Copy link

zefhemel commented Jul 29, 2024

Describe the issue

I'm using spellcheck="true" on my CodeMirror editor to enable native browser spell checking. Until @codemirror/view 6.28.0 this worked fine, it detected spelling errors and right clicking on a correct spelling would replace it in line. As of 6.28.0 this functionality is broken, however — it simply doesn't change the text anymore.

CleanShot 2024-07-29 at 12 03 40

In any version of @codemirror/view beyond 6.28.0 this is the case, so 6.27.0 still works.

Browser and platform

Chrome, testing on macOS

Reproduction link

No response

@marijnh
Copy link
Member

marijnh commented Jul 29, 2024

Apparently enabling Chrome's new EditContext feature blocks it from applying these kinds of corrections. Attached patch hooks into the beforeinput events they fire to actively apply them ourselves.

@zefhemel
Copy link
Author

Awesome, thanks a lot for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants