Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login rate limiter should not count against successful logins #2647

Closed
jsjoeio opened this issue Jan 28, 2021 · 1 comment · Fixed by #3141
Closed

Login rate limiter should not count against successful logins #2647

jsjoeio opened this issue Jan 28, 2021 · 1 comment · Fixed by #3141
Assignees
@jsjoeio
Labels
bug Something isn't working
Milestone
v3.10.0

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 28, 2021 •
edited
Loading

When running e2e tests against the login page, I'm hitting the login rate limit even though I'm using the correct password

image

Relevent code:
5accf3f
@jsjoeio jsjoeio added enhancement Some improvement that isn't a feature bug Something isn't working and removed enhancement Some improvement that isn't a feature labels Jan 28, 2021
@jsjoeio jsjoeio changed the title Disable login rate limiter in dev/test mode Login rate limiter should not count against successful logins Jan 28, 2021
@sr229
Copy link
Contributor

sr229 commented Jan 29, 2021

this looks like the limiter couldn't distinguish from successful logins to non-successful logins. Will give this a look later.

@jsjoeio jsjoeio mentioned this issue Feb 1, 2021
Merged
17 tasks
@jsjoeio jsjoeio added this to the On Deck milestone Apr 2, 2021
@jsjoeio jsjoeio mentioned this issue Apr 14, 2021
Merged
3 tasks
@jsjoeio jsjoeio modified the milestones: On Deck, v3.9.4 Apr 15, 2021
@jsjoeio jsjoeio self-assigned this Apr 15, 2021
@jsjoeio jsjoeio mentioned this issue Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging a pull request may close this issue.

fix(login): rate limiter shouldn't count successful logins coder/code-server
2 participants
@jsjoeio @sr229