Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev]: add check to e2e tests for connection #3270

Closed
jsjoeio opened this issue Apr 30, 2021 · 0 comments · Fixed by #3271
Closed

[dev]: add check to e2e tests for connection #3270

jsjoeio opened this issue Apr 30, 2021 · 0 comments · Fixed by #3271
Assignees
Labels
testing Anything related to testing
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 30, 2021

Problem

We've noticed the occasional timeout in e2e tests. In an effort to reduce flakiness due to connection timeouts, we think it would be beneficial to add a check for the connection.

Solution

Add method to CodeServer e2e model to check connection by asserting that the CODE_SERVER_ADDRESS shows up in the bottom left-corner. If it doesn't, reload.

@jsjoeio jsjoeio self-assigned this Apr 30, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label Apr 30, 2021
@jsjoeio jsjoeio added this to the v3.9.4 milestone Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant