Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use specific version of VSCode #601

Closed
mikestaub opened this issue Apr 25, 2019 · 11 comments
Closed

use specific version of VSCode #601

mikestaub opened this issue Apr 25, 2019 · 11 comments

Comments

@mikestaub
Copy link

Is it possible to use a customized version of VSCode? Either to use a specific version or a private fork?

@kylecarbs
Copy link
Member

Technically, yes. You could fork this repo and create a custom patch.

@mikestaub mikestaub reopened this Apr 26, 2019
@mikestaub
Copy link
Author

I would prefer not to fork the repo, but rather be able to create my own dockerfile that inherits from this one. If you explain to me how this can be done, I would be happy to submit a PR.

@morningspace
Copy link
Contributor

I have the same question... it looks my current vscode version being used by code-server is 1.33.1... The way that I check the version of vscode is typing printenv from the command line within the code-server container, it gives me:

TERM_PROGRAM=vscode
TERM_PROGRAM_VERSION=1.33.1

However, the latest vscode version at the time of my writing this comment is 1.35.1. It'd be great that this project can be sync w/ vscode in some way... Haven't had chance dive into the source code, but just did a quick check, it looks there's env var used by build script to define the dependent vscode version, at this place. Is that the only place to change if I want to use a specific version of vscode? I feel that would be helpful if that can be documented.

@kylecarbs @mikestaub

@deansheather
Copy link
Member

It's probably not a good idea to change the version of vscode you use without ensuring the patch is up to date with the changes, since a lot of things can change between vscode versions.

@morningspace
Copy link
Contributor

morningspace commented Jun 20, 2019

Yeah, that makes sense... just for people who are early adopters :-) If something broken because of incompatible changes introduced that are depended by code-server, then the one who switched the vscode version will have to "pay" for that :-)

On the other hand, it may be also helpful for code-server to apply newer version of vscode to get some sort of early feedback...

@deansheather

@code-asher
Copy link
Member

code-asher commented Jun 24, 2019

Once #795 #857 is finished it should be possible to use any VS Code version with code-server (it will mostly negate the need for a patch).

@morningspace
Copy link
Contributor

That sounds great... looking forward to this feature!

@jagraj
Copy link

jagraj commented Jul 30, 2019

@code-asher

Once #795 #857 is finished it should be possible to use any VS Code version with code-server (it will mostly negate the need for a patch).

When this feature is going to be available for the users.? Thank you.

@sr229
Copy link
Contributor

sr229 commented Sep 12, 2019

@code-asher

Once #795 #857 is finished it should be possible to use any VS Code version with code-server (it will mostly negate the need for a patch).

When this feature is going to be available for the users.? Thank you.

We just merged it on master! Go ahead try it now.

@sr229
Copy link
Contributor

sr229 commented Sep 12, 2019

Closing as implemented. Let us know if there are regressions as a seperate issue.

@sr229 sr229 closed this as completed Sep 12, 2019
@code-asher
Copy link
Member

code-asher commented Sep 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants