Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry.coder.com shows wrong version #229

Open
geiseri opened this issue Apr 18, 2024 · 4 comments · Fixed by #301
Open

registry.coder.com shows wrong version #229

geiseri opened this issue Apr 18, 2024 · 4 comments · Fixed by #301
Labels
docs Improvements or additions to documentation help wanted Extra attention is needed

Comments

@geiseri
Copy link

geiseri commented Apr 18, 2024

It looks like what is displayed on the website is the main branch, but the modules only can be accessed by a version tag. This might be an artifact of #157 though. This can cause confusion as the published documentation is not always correct.

@coder-labeler coder-labeler bot added the docs Improvements or additions to documentation label Apr 18, 2024
@matifali
Copy link
Member

As a workaround, @mafredri @kylecarbs we should pin https://registry.coder.com to our latest published tag for now.

But this is an issue too as our bump version in docs workflow triggers after the tag is pushed so the docs would then lag behind the actual published version.

@matifali matifali added the bug label Apr 18, 2024
@geiseri
Copy link
Author

geiseri commented Apr 18, 2024

As much as I HATE adding extra release steps, maybe it is best to have the version manually applied in the README.md metadata since there is a bunch of other stuff there too. One project that does this s vcpkg. They literally have 1000s of packages all kept in the same repository with very good QA on released versions.

@michaelbrewer
Copy link
Contributor

@matifali - can we add a script as part of the release to increment all of the readme?

@matifali
Copy link
Member

matifali commented Apr 18, 2024

@michaelbrewer we do have a script but it runs after the release (new tag) is published. We can modify and run it manually just before creating a release and it should solve the issue then.

Additionally we need to point registry.coder.com to latest published tag instead of main.

Thoughts @mafredri ?

@matifali matifali assigned matifali and unassigned matifali Sep 24, 2024
@matifali matifali removed the bug label Oct 14, 2024
@matifali matifali reopened this Dec 16, 2024
@coder-labeler coder-labeler bot added the help wanted Extra attention is needed label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants