Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forking off bevy_glfw #42

Closed
Friz64 opened this issue Nov 7, 2022 · 4 comments
Closed

Forking off bevy_glfw #42

Friz64 opened this issue Nov 7, 2022 · 4 comments

Comments

@Friz64
Copy link

Friz64 commented Nov 7, 2022

Hey there! I see that this repository has previously contained an GLFW backend for bevy_window, before being removed in d7bcf60.

I ask for permission to use that old code as a base for an actual bevy_glfw crate, where my aim is to improve and maintain it. I am planning to license the fork under MIT or Apache 2.0, as per the Bevy Third Party Plugin Guidelines. I will credit your name.

As an aside, my motivation behind this is that I personally find it inconvenient to use winit due to its lack of proper keyboard input handling, as I'm using a non-qwerty keyboard layout, Colemak, which scrambles the key mapping in games, making it very difficult to use without making an effort to remap all keys to their correct locations. GLFW, on the other hand, always assumes a qwerty layout, no matter where the keys are physically located on the keyboard, which is the preferred behaviour in games. There is work underway to fix this in winit, but it's not done yet (rust-windowing/winit#1806).

@coderedart
Copy link
Owner

sure. take whatever you want :)

Thanks for maintaining the erupt crate btw, It really helped me out when i was learning vulkan and used it in this repo in the past.

@Friz64
Copy link
Author

Friz64 commented Nov 12, 2022

I ended up rewriting most of the code (including using custom GLFW bindings), but here it is: https://docs.rs/bevy_glfw/

@coderedart
Copy link
Owner

any particular reason for writing generating new bindings?

@Friz64
Copy link
Author

Friz64 commented Nov 12, 2022

Allows more specialized and independent code, PistonDevelopers/glfw-rs has 8 years of historical baggage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants