Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Layout Ignored (Possibly Reading keyCode Instead Of key) #8320

Closed
2 tasks done
fweth opened this issue Feb 2, 2024 · 4 comments
Closed
2 tasks done

Keyboard Layout Ignored (Possibly Reading keyCode Instead Of key) #8320

fweth opened this issue Feb 2, 2024 · 4 comments

Comments

@fweth
Copy link

fweth commented Feb 2, 2024

🐛 bug report

Preflight Checklist

  • [x ] I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project
    adheres to.
  • I have searched the issue tracker for an issue that matches the one I want
    to file, without success.

Description of the problem

It seems that my keyboard layout (Colemak) is not recognized by CodeSandbox for shortcuts (like Cmd+N, Cmd+K). It seems to look at the keyCode and map it to some QWERTY layout instead of reading out the key property of a key event?

How has this issue affected you? What are you trying to accomplish?

Almost impossible to use if all my shortcuts are gone. This is also a known problem with VSCode, but in the VSCode settings, "keyboard.dispatch": "keyCode", does the trick (which is unintuitive, should be the other way around, but anyway, it works).

Your Environment

Software Name/Version
Сodesandbox
Browser Firefox 122.0b9
Operating System Ubuntu 23.04
@fweth
Copy link
Author

fweth commented Feb 4, 2024

Here is the relevant part from the VSCode docs, I don't know if the CSB editor depends on VSCode: https://github.com/Microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-linux-keybindings

@CompuIves
Copy link
Member

Good report, we use VSCode for these keybindings and we might be using the wrong default settings. Thanks for sharing the docs as well! Will investigatge.

@fweth
Copy link
Author

fweth commented Feb 20, 2024

Ah hey, I just realized that we can bring our own VSCode settings! In this case I think you did nothing wrong, key is the default in VSCode so it makes sense for CSB to mirror that behaviour, as long as the users can change it :)

@fweth fweth closed this as completed Feb 20, 2024
@tim-phillips
Copy link

Here's the relevant vscode issue: microsoft/vscode#23991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants