Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(landing): set pointerEvents to avoid reset button overlap #245

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

matchai
Copy link
Contributor

@matchai matchai commented Dec 8, 2021

What kind of change does this pull request introduce?

  1. Fix a bug blocking interaction with editors due to invisible elements overlapping
  2. Dim reset button when the editor contents are unchanged

What is the current behavior?

CleanShot.2021-12-06.at.17.20.15.mp4
  1. Reset button gives the impression that the reset button will do something while it's visible.

What is the new behavior?

  1. Invisible elements are given pointerEvents: "none".
  2. Reset button is dimmed if editor contents are unchanged.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

Locally tested both interactions:

  1. Reset button now works consistently.
  2. Reset button is dimmed until changes are made in the editor.
CleanShot.2021-12-08.at.18.14.08-converted.mp4

Checklist

  • Documentation N/A
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3cc1654:

Sandbox Source
Sandpack Blog Example 1 Configuration

@danilowoz
Copy link
Member

That's great! Thanks @matchai!

@danilowoz danilowoz merged commit 51be6cf into main Dec 8, 2021
@danilowoz danilowoz deleted the matan-polish branch December 8, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants