Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): gruvbox light and dark #600

Merged
merged 4 commits into from
Oct 4, 2022
Merged

feat(theme): gruvbox light and dark #600

merged 4 commits into from
Oct 4, 2022

Conversation

griimick
Copy link
Contributor

@griimick griimick commented Oct 1, 2022 •
edited
Loading

What kind of change does this pull request introduce?

Introduces themes inspired by gruvbox color scheme. This PR includes both light and dark themes.

What is the new behavior?

gruvboxDark
gruvboxDarkError
gruvboxLight
gruvboxLightError

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Test build after adding two themes under sandpack-themes/src and adding their entry to sandpack-themes/src/index.ts.
  2. Run Storybook and verify the results.

Checklist

  • Documentation;
  • Storybook (if applicable);
  • Tests;
  • Ready to be merged;

@codesandbox
Copy link

codesandbox bot commented Oct 1, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8d0c33c:

Sandbox Source
Sandpack Configuration

danilowoz
danilowoz approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you for your contribution, @griimick!

@danilowoz danilowoz merged commit 3d93fc0 into codesandbox:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilowoz danilowoz danilowoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@griimick @danilowoz