Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-vite template): use automatic runtime for jsx #720

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Feb 17, 2023

I implemented automatic runtime for VITE-REACT template.

🤯🤯🤯 This is magic, it works in the browser

@vercel
Copy link

vercel bot commented Feb 17, 2023

@jeetiss is attempting to deploy a commit to the CodeSandbox Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you! Just left a question

vite: "4.0.0",
"esbuild-wasm": "0.15.12",
},
}),
},
"/vite.config.js": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React plugin auto inject React on every jsx file? Interesting!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it uses automatic jsx runtime.

Here the docs:
https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html

@danilowoz danilowoz changed the title use automatic runtime for jsx in VITE-REACT fix(react-vite template): use automatic runtime for jsx in VITE-REACT Feb 17, 2023
@danilowoz danilowoz changed the title fix(react-vite template): use automatic runtime for jsx in VITE-REACT fix(react-vite template): use automatic runtime for jsx Feb 17, 2023
@vercel
Copy link

vercel bot commented Feb 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sandpack-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 11:44AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants