fix(SandpackCodeEditor): add className prop #896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
This change adds a
className
prop to theSandpackCodeEditor
component that gets merged with the rootSandpackStack
classes. The motivation behind this change is that I'd like to style the editor using tailwind, which isn't possible with the current setup. The change is similar to the existing implementation in the SandpackPreview component.What is the current behavior?
The only way to style a
SandpackCodeEditor
component currently is to use thestyle
prop.What is the new behavior?
A new
className
prop has been added to theSandpackCodeEditor
component to make it possible to style the editor using class names.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
I added the
className
prop to a few stories in Storybook and was able to see that theclasses
were applied to the correct element in the DOM.Checklist