From e1ec9aa18145bb50f6066275edab7f81eb86fa39 Mon Sep 17 00:00:00 2001
From: maayarosama <66883096+maayarosama@users.noreply.github.com>
Date: Wed, 6 Mar 2024 16:04:17 +0200
Subject: [PATCH] Development admin accessibility (#367)

* Adding access to admin to request vacations for other users

* Adding admin endpoit

* fixing vacation card error

* Development admin accessibility backend (#368)

* Implementation: Implemented an endpoint for admins to post vacations behalf of the user.

* Enhancement: rename the route of the admin vacations request

* Typo: replaced the pinding by pending.

* Using enum in selectionOption and exporting ListUsers in helpers

---------

Co-authored-by: Thunder <mahmmoud.hassanein@gmail.com>
---
 client/src/clients/api/vacations.ts           |  17 ++
 client/src/components/SetUserVacations.vue    |  38 ++--
 client/src/components/UpdateUser.vue          |  31 ++--
 client/src/components/cards/vacationCard.vue  |   3 +-
 .../src/components/requests/leaveRequest.vue  | 134 ++++++++++++--
 client/src/types/index.ts                     |   7 +-
 client/src/utils/helpers.ts                   |  17 ++
 server/cshr/routes/vacations.py               |   2 +
 server/cshr/serializers/vacations.py          |   5 +
 server/cshr/services/compensation.py          |   2 +-
 server/cshr/services/hr_letters.py            |   2 +-
 server/cshr/services/official_documents.py    |   4 +-
 server/cshr/services/requests.py              |  12 +-
 server/cshr/utils/redis_functions.py          |   2 +-
 server/cshr/utils/vacation_balance_helper.py  |   2 +-
 server/cshr/views/compensation.py             |   2 +-
 server/cshr/views/vacations.py                | 165 ++++++++++++++++--
 17 files changed, 352 insertions(+), 93 deletions(-)

diff --git a/client/src/clients/api/vacations.ts b/client/src/clients/api/vacations.ts
index f882c78f9..cf423b744 100644
--- a/client/src/clients/api/vacations.ts
+++ b/client/src/clients/api/vacations.ts
@@ -12,6 +12,7 @@ export class VacationsApi extends ApiClientBase {
   readonly edit: VacationsEditApi
   readonly get_admin_balance: VacationsGetAdminBalanceApi
   readonly post_admin_balance: VacationsPostAdminBalanceApi
+  readonly admin: VacationsAdmin
   readonly user: VacationsUserApi
 
   constructor(options: Api.ClientOptions) {
@@ -25,6 +26,7 @@ export class VacationsApi extends ApiClientBase {
     this.edit = new VacationsEditApi(options, this.path)
     this.get_admin_balance = new VacationsGetAdminBalanceApi(options, this.path)
     this.post_admin_balance = new VacationsPostAdminBalanceApi(options, this.path)
+    this.admin= new VacationsAdmin(options, this.path)
     this.user = new VacationsUserApi(options, this.path)
   }
 
@@ -168,6 +170,21 @@ class VacationsGetAdminBalanceApi extends ApiClientBase {
     })
   }
 }
+class VacationsAdmin extends ApiClientBase {
+  protected readonly path = '/admin'
+
+
+  async create(id: number, input: Api.Inputs.Leave) {
+    ApiClientBase.assertUser()
+    const vacation = await this.unwrap(
+      () => this.$http.post<Api.Returns.LeaveRequest>(this.getUrl(`/${id}`), input),
+      { transform: (d) => d.results }
+    )
+
+    return vacation
+  }
+}
+
 
 class VacationsPostAdminBalanceApi extends ApiClientBase {
   protected readonly path = '/post-admin-balance'
diff --git a/client/src/components/SetUserVacations.vue b/client/src/components/SetUserVacations.vue
index 1df4a2d52..c17cd4c0c 100644
--- a/client/src/components/SetUserVacations.vue
+++ b/client/src/components/SetUserVacations.vue
@@ -80,17 +80,8 @@
 
             <template #append-item v-if="reloadMore">
               <VContainer>
-                <VBtn
-                  @click="
-                    () => {
-                      return page++, count--, listUsers()
-                    }
-                  "
-                  block
-                  color="secondary"
-                  variant="tonal"
-                  prepend-icon="mdi-reload"
-                >
+                <VBtn @click="() => { return page++, count--, concatUsers() }" block color="secondary" variant="tonal"
+                  prepend-icon="mdi-reload">
                   Load More Users
                 </VBtn>
               </VContainer>
@@ -136,7 +127,7 @@
 
 <script lang="ts">
 import { $api } from '@/clients'
-import { requiredRules, requiredStringRules, vacationRules } from '@/utils'
+import { listUsers, requiredRules, requiredStringRules, vacationRules } from '@/utils'
 import { onMounted, ref, watchEffect, computed } from 'vue'
 import { useAsyncState } from '@vueuse/core'
 import { ApiClientBase } from '@/clients/api/base'
@@ -276,21 +267,18 @@ export default {
       }
     })
 
-    async function listUsers() {
-      const res = await $api.users.admin.office_users.list({ page: page.value })
-      if (res.count) {
-        count.value = Math.ceil(res.count / 10)
-      } else {
-        count.value = 0
-      }
-      res.results.forEach((user: any) => {
-        officeUsers.value.push(user)
-      })
-      return officeUsers.value
+    async function concatUsers() {
+      const { page: currentPage, count: currentCount, users: newUsers } = await listUsers($api, page.value, count.value);
+
+      page.value = currentPage;
+      count.value = currentCount;
+      officeUsers.value = officeUsers.value.concat(newUsers);
     }
+
+
     onMounted(async () => {
       try {
-        await listUsers()
+        await concatUsers()
         selectedUsers.value.push(officeUsers.value[0])
         await getUserBalance()
       } catch (error) {
@@ -322,7 +310,7 @@ export default {
       vacationRules,
       isLoading,
       reloadMore,
-      listUsers,
+      concatUsers,
       execute,
       setUserBalanceValues,
       userBalance,
diff --git a/client/src/components/UpdateUser.vue b/client/src/components/UpdateUser.vue
index 903bca523..6be5faffd 100644
--- a/client/src/components/UpdateUser.vue
+++ b/client/src/components/UpdateUser.vue
@@ -9,7 +9,7 @@
 
             <template #append-item v-if="reloadMore">
               <VContainer>
-                <VBtn @click="() => { return page++, count--, listUsers() }" block color="secondary" variant="tonal"
+                <VBtn @click="() => { return page++, count--,  concatUsers()}" block color="secondary" variant="tonal"
                   prepend-icon="mdi-reload">
                   Load More Users
                 </VBtn>
@@ -114,7 +114,8 @@ import {
   telegramRules,
   requiredStringRules,
   requiredRules,
-  formatDate
+  formatDate,
+  listUsers
 } from '@/utils'
 import { useAsyncState } from '@vueuse/core'
 import { ApiClientBase } from '@/clients/api/base'
@@ -166,18 +167,6 @@ export default {
       }
       return false;
     });
-    async function listUsers() {
-      const res = await $api.users.admin.office_users.list({ page: page.value })
-      if (res.count) {
-        count.value = Math.ceil(res.count / 10)
-      } else {
-        count.value = 0
-      }
-      res.results.forEach((user: any) => {
-        officeUsers.value.push(user)
-      })
-      return officeUsers.value
-    }
 
     async function listSupervisors() {
       const res = await $api.users.supervisors.list({ page: supervisorPage.value })
@@ -193,13 +182,21 @@ export default {
       return supervisors.value
     }
 
+    async function concatUsers() {
+      const { page: currentPage, count: currentCount, users: newUsers } = await listUsers($api, page.value, count.value);
+
+      page.value = currentPage;
+      count.value = currentCount;
+      officeUsers.value = officeUsers.value.concat(newUsers);
+    }
+
     onMounted(async () => {
       try {
         offices.value = (await $api.office.list()).map((office: any) => ({
           id: office.id,
           name: office.name
-        }))
-        await listUsers()
+        }));
+        await concatUsers()
         selectedUser.value = officeUsers.value[0]
         await listSupervisors()
         reporting_to.value = selectedUser.value?.reporting_to[0]
@@ -299,7 +296,7 @@ export default {
       page,
       reloadMore,
       reloadMoreSupervisor,
-      listUsers,
+      concatUsers,
       chooseImage
     }
   }
diff --git a/client/src/components/cards/vacationCard.vue b/client/src/components/cards/vacationCard.vue
index c75ced8e7..b683296bf 100644
--- a/client/src/components/cards/vacationCard.vue
+++ b/client/src/components/cards/vacationCard.vue
@@ -13,6 +13,7 @@
         <b color="primary">{{ vacation.end_date }} </b> vacation
 
       </p>
+
       <v-form ref="form" @submit.prevent="updateVacation()">
 
         <v-row class="d-flex justify-center my-2" v-if="couldUpdate">
@@ -157,7 +158,7 @@ export default {
             return true
           }
           if (
-            props.vacation.user.reporting_to[0].id === props.vacation.user?.id &&
+            props.vacation.user.reporting_to[0]?.id === props.vacation.user?.id &&
             props.vacation.user.location.name === user.value.fullUser.location.name
           ) {
             return true
diff --git a/client/src/components/requests/leaveRequest.vue b/client/src/components/requests/leaveRequest.vue
index 045356830..4e789c90a 100644
--- a/client/src/components/requests/leaveRequest.vue
+++ b/client/src/components/requests/leaveRequest.vue
@@ -3,6 +3,25 @@
     <v-alert v-if="form?.isValid && isValid" density="compact" class="pa-5 my-5" type="warning">
       {{ actualDays.state.value === 0 ? "Actual vacation days requested is zero, Selected days might include weekends or public holidays" : "Actual vacation days requested are " + actualDays.state.value +" days" }}
     </v-alert>
+    <div class="mt-3" v-if="user?.fullUser.user_type === 'Admin'"> <v-radio-group inline v-model="selectedOption">
+        <v-radio label="For yourself" value="me"></v-radio>
+        <v-radio label="For Another User" value="anotheruser"></v-radio>
+      </v-radio-group> </div>
+    <div class="mt-3" v-if="selectedOption === 'anotheruser'">
+      <v-autocomplete color="info" item-color="info" base-color="info" variant="outlined" v-model="selectedUser"
+        :items="officeUsers" item-title="full_name" item-value="id" label="User" return-object :rules="requiredRules">
+
+        <template #append-item v-if="reloadMore">
+          <VContainer>
+            <VBtn @click="() => { return page++, count--, concatUsers() }" block color="secondary" variant="tonal"
+              prepend-icon="mdi-reload">
+              Load More Users
+            </VBtn>
+          </VContainer>
+        </template>
+      </v-autocomplete>
+
+    </div>
 
     <div class="mt-3">
       <v-text-field ref="startDateField" color="info" item-color="info" base-color="info" variant="outlined"
@@ -26,7 +45,8 @@
 </template>
 <script lang="ts">
 import { useApi } from '@/hooks'
-import type { Api } from '@/types';
+import { Selection, type Api } from '@/types';
+import { requiredRules, listUsers } from '@/utils'
 import { useAsyncState } from '@vueuse/core';
 import { computed, onMounted, ref, watch } from 'vue';
 import { ApiClientBase } from '@/clients/api/base';
@@ -40,6 +60,11 @@ export default {
   setup(props, ctx) {
     const $api = useApi()
     const form = ref()
+    const officeUsers = ref<any[]>([]);
+    const selectedUser = ref()
+    const selectedOption = ref<Selection>(Selection.ME)
+    const page = ref(1)
+    const count = ref(0)
     const startDateField = ref()
     const endDateField = ref()
     const startDate = ref<Date>(props.dates.startStr)
@@ -47,8 +72,9 @@ export default {
     endDate.value.setDate(endDate.value.getDate() - 1);
     endDate.value = endDate.value.toISOString().split('T')[0];
     const user = ApiClientBase.user
+    const userId = ref<number | undefined>()
     const leaveReason = ref<Api.LeaveReason>()
-
+    const leaveReasons = ref<Api.LeaveReason[]>([])
     const actualDays = useAsyncState(
       async () => {
         return $api.vacations.calculate.list({
@@ -64,9 +90,9 @@ export default {
       let val = leaveReason.value ? true : false;
       return val;
     });
-    const leaveReasons = ref<Api.LeaveReason[]>([])
 
-    const balance = useAsyncState($api.vacations.getVacationBalance({ "user_ids": user.value?.fullUser.id }), null, {
+    const balance = useAsyncState(() => $api.vacations.getVacationBalance({ "user_ids": userId.value }), null, {
+      immediate: false,
       onSuccess(data: any) {
         leaveReasons.value = [{
           name: `Emergency Leaves  ${data[0].emergency_leaves.reserved} / ${data[0].emergency_leaves.all}`,
@@ -91,6 +117,33 @@ export default {
       }
     })
 
+    watch(
+      () => [selectedOption.value],
+      () => {
+        if (selectedOption.value === Selection.ANOTHERUSER) {
+          selectedUser.value = officeUsers.value[0]
+        } else {
+          selectedUser.value = undefined
+          userId.value = user.value?.fullUser.id
+          balance.execute()
+
+        }
+
+      },
+    );
+
+    watch(
+      () => [selectedUser.value],
+      async () => {
+        if (selectedUser.value) {
+          userId.value = selectedUser.value.id
+          balance.execute()
+        }
+      },
+    );
+
+
+
 
     watch(
       () => [startDate.value, endDate.value],
@@ -110,27 +163,64 @@ export default {
       return true;
     };
 
-    onMounted(() => {
+    async function concatUsers() {
+      const { page: currentPage, count: currentCount, users: newUsers } = await listUsers($api, page.value, count.value);
+
+      page.value = currentPage;
+      count.value = currentCount;
+      officeUsers.value = officeUsers.value.concat(newUsers);
+    }
+    onMounted(async () => {
+
       startDateField.value.validate();
       endDateField.value.validate();
-
+      userId.value = user.value?.fullUser.id
+      balance.execute()
+      concatUsers()
     })
+    const reloadMore = computed(() => {
+      if (page.value === count.value) {
+        return false
+      }
+      if (count.value > 1) {
+        return true
+      }
+      return false;
+    });
 
     async function createLeave() {
       if (leaveReason.value) {
-        useAsyncState($api.vacations.create(
-          {
-            reason: leaveReason.value.reason,
-            from_date: startDate.value,
-            end_date: endDate.value
-          }),
-          undefined,
-          {
-            onSuccess(data) {
-              ctx.emit('create-event', data)
+        if (selectedOption.value === Selection.ANOTHERUSER) {
+          useAsyncState(
+            $api.vacations.admin.create(selectedUser.value.id, {
+              reason: leaveReason.value.reason,
+              from_date: startDate.value,
+              end_date: endDate.value,
+            }),
+            null,
+            {
+              onSuccess(data) {
+                ctx.emit('create-event', data)
+              }
+            }
+          )
+
+        }
+        else {
+          useAsyncState($api.vacations.create(
+            {
+              reason: leaveReason.value.reason,
+              from_date: startDate.value,
+              end_date: endDate.value
+            }),
+            undefined,
+            {
+              onSuccess(data) {
+                ctx.emit('create-event', data)
+              }
             }
-          }
-        )
+          )
+        }
       }
     }
 
@@ -145,6 +235,14 @@ export default {
       user,
       startDateField,
       endDateField,
+      requiredRules,
+      reloadMore,
+      selectedUser,
+      officeUsers,
+      page,
+      count,
+      selectedOption,
+      concatUsers,
       createLeave,
       validateDates,
     };
diff --git a/client/src/types/index.ts b/client/src/types/index.ts
index 30ea369e6..9687ee7b6 100644
--- a/client/src/types/index.ts
+++ b/client/src/types/index.ts
@@ -12,4 +12,9 @@ export interface JWTokenObject {
     iat: number
     jti: string
     user_id: number
-}
\ No newline at end of file
+}
+
+export enum Selection {
+    ME = "me",
+    ANOTHERUSER = "anotheruser",
+  }
\ No newline at end of file
diff --git a/client/src/utils/helpers.ts b/client/src/utils/helpers.ts
index 401432363..2ed5bd648 100644
--- a/client/src/utils/helpers.ts
+++ b/client/src/utils/helpers.ts
@@ -2,6 +2,7 @@ import moment from 'moment'
 
 import type { Api } from "@/types"
 import type { JWTokenObject } from "@/types"
+import type { ApiClient } from '@/clients/api'
 
 export async function resolve<T>(promise: Promise<T>): Promise<[T, any]> {
   try {
@@ -162,4 +163,20 @@ export function decodeAccessToken(token: string): JWTokenObject {
 export function isValidToken(token: string): boolean {
   const decodedToken = decodeAccessToken(token);
   return Date.now() < decodedToken.exp * 1000;
+}
+
+export async function listUsers($api: ApiClient, page: number, count: number): Promise<{ page: number, count: number,  users: any[]}> {
+  
+    const res = await $api.users.admin.office_users.list({ page });
+    let users: any[] = [];
+    if (res.count) {
+      count = Math.ceil(res.count / 10)
+    } else {
+      count = 0
+    }
+    res.results.forEach((user: any) => {
+      users.push(user)
+    })
+    return { page, count, users };
+
 }
\ No newline at end of file
diff --git a/server/cshr/routes/vacations.py b/server/cshr/routes/vacations.py
index 11f1fc2cb..73268c94f 100644
--- a/server/cshr/routes/vacations.py
+++ b/server/cshr/routes/vacations.py
@@ -12,6 +12,7 @@
     GetAdminVacationBalanceApiView,
     CalculateVacationDaysApiView,
     VacationBalanceAdjustmentApiView,
+    AdminApplyVacationForUserApiView
 )
 
 urlpatterns = [
@@ -27,4 +28,5 @@
     path("reject/<str:id>/", VacationsRejectApiView.as_view()),
     path("<str:id>/", VacationsHelpersApiView.as_view()),
     path("comment/<str:id>/", VacationCommentsAPIView.as_view()),
+    path("admin/<str:user_id>/", AdminApplyVacationForUserApiView.as_view()),
 ]
diff --git a/server/cshr/serializers/vacations.py b/server/cshr/serializers/vacations.py
index 18d22199a..0fed7ded9 100644
--- a/server/cshr/serializers/vacations.py
+++ b/server/cshr/serializers/vacations.py
@@ -239,3 +239,8 @@ class VacationBalanceAdjustmentSerializer(serializers.Serializer):
     officeId = serializers.IntegerField()
     value = serializers.IntegerField()
     reason = serializers.CharField()
+
+class AdminApplyVacationForUserSerializer(serializers.Serializer):
+    reason = serializers.CharField()
+    from_date = serializers.DateField()
+    end_date = serializers.DateField()
diff --git a/server/cshr/services/compensation.py b/server/cshr/services/compensation.py
index 0309590b6..4d72acceb 100644
--- a/server/cshr/services/compensation.py
+++ b/server/cshr/services/compensation.py
@@ -15,7 +15,7 @@ def get_all_compensations() -> Compensation:
     return Compensation.objects.all()
 
 
-def filter_all_compensations_by_pinding_status() -> Compensation:
+def filter_all_compensations_by_pending_status() -> Compensation:
     """Return all compensations"""
     return Compensation.objects.filter(status=STATUS_CHOICES.PENDING)
 
diff --git a/server/cshr/services/hr_letters.py b/server/cshr/services/hr_letters.py
index eb0fd8f0a..e62c4bcf7 100644
--- a/server/cshr/services/hr_letters.py
+++ b/server/cshr/services/hr_letters.py
@@ -26,5 +26,5 @@ def filter_all_docs_based_on_user(user: User):
     return UserDocuments.objects.filter(user=user)
 
 
-def filter_hr_letter_by_pinding_status():
+def filter_hr_letter_by_pending_status():
     return HrLetters.objects.filter(status=STATUS_CHOICES.PENDING)
diff --git a/server/cshr/services/official_documents.py b/server/cshr/services/official_documents.py
index ea653af5f..215c0b775 100644
--- a/server/cshr/services/official_documents.py
+++ b/server/cshr/services/official_documents.py
@@ -2,8 +2,8 @@
 from cshr.models.requests import STATUS_CHOICES
 
 
-def filter_all_official_docs_by_pinding_status():
-    """Method helper to filter all official documents by pinding status"""
+def filter_all_official_docs_by_pending_status():
+    """Method helper to filter all official documents by pending status"""
     return OffcialDocument.objects.filter(status=STATUS_CHOICES.PENDING)
 
 
diff --git a/server/cshr/services/requests.py b/server/cshr/services/requests.py
index 6776c4298..aee763475 100644
--- a/server/cshr/services/requests.py
+++ b/server/cshr/services/requests.py
@@ -3,18 +3,18 @@
 from cshr.serializers.official_documents import OffcialDocumentSerializer
 from cshr.models.users import USER_TYPE, User
 from cshr.services.hr_letters import (
-    filter_hr_letter_by_pinding_status,
+    filter_hr_letter_by_pending_status,
     get_hr_letter_by_user,
 )
 from cshr.services.official_documents import (
-    filter_all_official_docs_by_pinding_status,
+    filter_all_official_docs_by_pending_status,
 )
 from cshr.services.vacations import (
     filter_user_vacations,
     filter_vacations_by_pending_status,
 )
 from cshr.services.compensation import (
-    filter_all_compensations_by_pinding_status,
+    filter_all_compensations_by_pending_status,
     get_compensations_by_user,
 )
 from typing import List, Dict
@@ -42,14 +42,14 @@ def requests_format_response(user: User) -> Dict:
         official_docs: List[OffcialDocument] = []
     elif user.user_type == USER_TYPE.ADMIN:
         hr_letters: List[HrLetters] = LandingPageHrLetterSerializer(
-            filter_hr_letter_by_pinding_status(), many=True
+            filter_hr_letter_by_pending_status(), many=True
         ).data
         vacations: List[Vacation] = []
         official_docs: List[OffcialDocument] = OffcialDocumentSerializer(
-            filter_all_official_docs_by_pinding_status(), many=True
+            filter_all_official_docs_by_pending_status(), many=True
         ).data
         compensations: List[Compensation] = LandingPageCompensationSerializer(
-            filter_all_compensations_by_pinding_status(), many=True
+            filter_all_compensations_by_pending_status(), many=True
         ).data
     else:
         # ==> USER_TYPE.SUPERVISOR
diff --git a/server/cshr/utils/redis_functions.py b/server/cshr/utils/redis_functions.py
index a864f5a6e..3c14913dd 100644
--- a/server/cshr/utils/redis_functions.py
+++ b/server/cshr/utils/redis_functions.py
@@ -23,7 +23,7 @@
 def set_notification_request_redis(data: Dict) -> bool:
     """this function set requests notifications"""
     applying_user = None
-    if type(data["applying_user"]) is not int and data.get("applying_user").get("id"):
+    if type(data.get("applying_user")) is not int and data.get("applying_user").get("id"):
         applying_user = data["applying_user"]["id"]
     else:
         applying_user = data["applying_user"]
diff --git a/server/cshr/utils/vacation_balance_helper.py b/server/cshr/utils/vacation_balance_helper.py
index 436883f79..30e741998 100644
--- a/server/cshr/utils/vacation_balance_helper.py
+++ b/server/cshr/utils/vacation_balance_helper.py
@@ -104,7 +104,7 @@ def check_and_update_balance(
                 if vacation.status == STATUS_CHOICES.PENDING:
                     new_value: int = curr_balance - vacation_days
                     return self.update_user_balance(applying_user, reason, new_value)
-                return f"The vacation status is not pinding, it's {vacation.status}."
+                return f"The vacation status is not pending, it's {vacation.status}."
             return f"You only have {curr_balance} days left of reason '{reason.capitalize().replace('_', ' ')}'"
         return "Unknown reason."
 
diff --git a/server/cshr/views/compensation.py b/server/cshr/views/compensation.py
index 6785a2069..892d9d85c 100644
--- a/server/cshr/views/compensation.py
+++ b/server/cshr/views/compensation.py
@@ -101,7 +101,7 @@ def delete(self, request: Request, id, format=None) -> Response:
             return CustomResponse.not_found(message="Compensation not found")
         if compensation.status != STATUS_CHOICES.PENDING:
             return CustomResponse.bad_request(
-                message="You can only delete requests with pinding status."
+                message="You can only delete requests with pending status."
             )
         if compensation.applying_user != request.user:
             return CustomResponse.unauthorized()
diff --git a/server/cshr/views/vacations.py b/server/cshr/views/vacations.py
index 8aa61897b..9ba1b1f50 100644
--- a/server/cshr/views/vacations.py
+++ b/server/cshr/views/vacations.py
@@ -1,5 +1,6 @@
 from cshr.serializers.users import TeamSerializer
 from cshr.serializers.vacations import (
+    AdminApplyVacationForUserSerializer,
     PostOfficeVacationBalanceSerializer,
     GetOfficeVacationBalanceSerializer,
     CalculateBalanceSerializer,
@@ -27,7 +28,6 @@
 from cshr.services.users import get_user_by_id, get_users_by_id
 from cshr.services.vacations import (
     filter_balances_by_users,
-    get_balance_by_user,
     get_vacation_by_id,
     get_all_vacations,
     send_vacation_to_calendar,
@@ -52,7 +52,6 @@
     OfficeVacationBalance,
     PublicHoliday,
     Vacation,
-    VacationBalance,
 )
 from cshr.services.vacations import get_vacations_by_user
 from cshr.utils.redis_functions import (
@@ -217,19 +216,20 @@ def post(self, request: Request) -> Response:
         if serializer.is_valid():
             start_date = serializer.validated_data.get("from_date")
             end_date = serializer.validated_data.get("end_date")
+            applying_user = request.user
 
-            # Check if there are pinding vacations in the same day
-            pinding_requests = Vacation.objects.filter(
+            # Check if there are pending vacations in the same day.
+            pending_requests = Vacation.objects.filter(
                 from_date__day=start_date.day,
                 end_date__day=end_date.day,
                 status=STATUS_CHOICES.PENDING,
+                applying_user=applying_user
             )
-            if len(pinding_requests) > 0:
+            if len(pending_requests) > 0:
                 return CustomResponse.bad_request(
                     message="You have a request with a pending status on the same day. Kindly address the pending requests first by either deleting them or reaching out to the administrators for approval/rejection."
                 )
 
-            applying_user = request.user
             # Check balance.
             v = StanderdVacationBalance()
             v.check(applying_user)
@@ -253,13 +253,13 @@ def post(self, request: Request) -> Response:
 
             curr_balance = getattr(user_reason_balance, reason)
 
-            pinding_vacations = Vacation.objects.filter(
+            pending_vacations = Vacation.objects.filter(
                 status=STATUS_CHOICES.PENDING,
                 applying_user=applying_user,
                 reason=reason,
             ).values_list("actual_days", flat=True)
 
-            chcked_balance = curr_balance - sum(pinding_vacations)
+            chcked_balance = curr_balance - sum(pending_vacations)
 
             if curr_balance < vacation_days:
                 return CustomResponse.bad_request(
@@ -268,7 +268,7 @@ def post(self, request: Request) -> Response:
 
             if chcked_balance < vacation_days:
                 return CustomResponse.bad_request(
-                    message=f"You have an additional pending request that deducts {sum(pinding_vacations)} days from your balance even though the current balance for the '{reason.capitalize().replace('_', ' ')}' category is only {curr_balance} days."
+                    message=f"You have an additional pending request that deducts {sum(pending_vacations)} days from your balance even though the current balance for the '{reason.capitalize().replace('_', ' ')}' category is only {curr_balance} days."
                 )
 
             saved = serializer.save(
@@ -293,11 +293,11 @@ def post(self, request: Request) -> Response:
             # if not sent:
             #     return CustomResponse.bad_request(message="Error in sending email, can not sent email with this request.")
 
-            response_date: Dict = send_vacation_to_calendar(saved)
+            response_data: Dict = send_vacation_to_calendar(saved)
             return CustomResponse.success(
                 status_code=201,
                 message="The vacation has been posted successfully.",
-                data=response_date,
+                data=response_data,
             )
         return CustomResponse.bad_request(error=serializer.errors)
 
@@ -367,13 +367,13 @@ def put(self, request: Request, id: str, format=None) -> Response:
             start_date = serializer.validated_data.get("from_date")
             end_date = serializer.validated_data.get("end_date")
 
-            # Check if there are pinding vacations in the same day
-            pinding_requests = Vacation.objects.filter(
+            # Check if there are pending vacations in the same day
+            pending_requests = Vacation.objects.filter(
                 from_date__day=start_date.day,
                 end_date__day=end_date.day,
                 status=STATUS_CHOICES.PENDING,
             )
-            if len(pinding_requests) > 0:
+            if len(pending_requests) > 0:
                 return CustomResponse.bad_request(
                     message="You have a request with a pending status on the same day. Kindly address the pending requests first by either deleting them or reaching out to the administrators for approval/rejection."
                 )
@@ -387,13 +387,13 @@ def put(self, request: Request, id: str, format=None) -> Response:
 
             curr_balance = getattr(user_reason_balance, reason)
 
-            pinding_vacations = Vacation.objects.filter(
+            pending_vacations = Vacation.objects.filter(
                 status=STATUS_CHOICES.PENDING,
                 applying_user=applying_user,
                 reason=reason,
             ).values_list("actual_days", flat=True)
 
-            chcked_balance = curr_balance - sum(pinding_vacations)
+            chcked_balance = curr_balance - sum(pending_vacations)
 
             if curr_balance < vacation_days:
                 return CustomResponse.bad_request(
@@ -402,7 +402,7 @@ def put(self, request: Request, id: str, format=None) -> Response:
 
             if chcked_balance < vacation_days:
                 return CustomResponse.bad_request(
-                    message=f"You have an additional pending request that deducts {sum(pinding_vacations)} days from your balance even though the current balance for the '{reason.capitalize().replace('_', ' ')}' category is only {curr_balance} days."
+                    message=f"You have an additional pending request that deducts {sum(pending_vacations)} days from your balance even though the current balance for the '{reason.capitalize().replace('_', ' ')}' category is only {curr_balance} days."
                 )
 
             serializer.save()
@@ -518,7 +518,7 @@ def put(self, request: Request, id: str, format=None) -> Response:
 
         if vacation.status != STATUS_CHOICES.PENDING:
             return CustomResponse.bad_request(
-                message=f"The vacation status is not pinding, it's {vacation.status}."
+                message=f"The vacation status is not pending, it's {vacation.status}."
             )
 
         current_user: User = get_user_by_id(request.user.id)
@@ -754,3 +754,132 @@ def get(self, request: Request) -> Response:
 
         # actual_days = len(actual_days) if actual_days != None else 0
         return CustomResponse.success(message="Balance calculated.", data=actual_days)
+
+class AdminApplyVacationForUserApiView(GenericAPIView):
+    permission_classes = [ IsAdmin ]
+    serializer_class = AdminApplyVacationForUserSerializer
+
+    def post(self, request: Request, user_id: str) -> Response:
+        """
+        ## Apply for Vacation on Behalf of Another User
+        This function allows the administrator to apply for a vacation on behalf of another user, but only if they work in the same office.
+        ### Parameters:
+        - **user_id** (`int`): The ID of the user for whom the vacation is being requested.
+        - **reason** (`str`): A string describing the reason for the vacation request.
+        - **from_date** (`datetime`): The starting date of the vacation.
+        - **end_date** (`datetime`): The ending date of the vacation.
+        """
+        admin = request.user
+        serializer = self.serializer_class(data=request.data)
+
+        if serializer.is_valid():
+            applying_user = get_user_by_id(user_id)
+            if applying_user is None:
+                return CustomResponse.not_found(message="User not found.")
+
+            if applying_user.location.id != admin.location.id:
+                return CustomResponse.unauthorized(message=f"This action can only be performed by administrators who work in the {applying_user.location.name} office.")
+
+            known_reasons = [REASON_CHOICES.ANNUAL_LEAVES, REASON_CHOICES.EMERGENCY_LEAVE, REASON_CHOICES.COMPENSATION, REASON_CHOICES.LEAVE_EXCUSES, REASON_CHOICES.UNPAID, REASON_CHOICES.SICK_LEAVES]
+            reason = serializer.validated_data.get('reason')
+            if reason not in known_reasons:
+                formatted_string = ', '.join(known_reasons[:-1]) + f' and {known_reasons[-1]}'
+                return CustomResponse.bad_request(message=f"reason {reason} is not valid, the available resons are {formatted_string}")
+
+            from_date = serializer.validated_data.get('from_date')
+            end_date = serializer.validated_data.get('end_date')
+
+            # Check if there are pending vacations in the same day
+            pending_requests = Vacation.objects.filter(
+                applying_user=applying_user,
+                from_date__day=from_date.day,
+                end_date__day=end_date.day,
+                status=STATUS_CHOICES.PENDING,
+            )
+
+            if len(pending_requests) > 0:
+                return CustomResponse.bad_request(
+                    message="The selected user has another request with the same dates and pending status. Please review their previous request before submitting a new one."
+                )
+
+            # Check balance.
+            v = StanderdVacationBalance()
+            v.check(applying_user)
+
+            user_reason_balance = applying_user.vacationbalance
+            vacation_days = v.get_actual_days(applying_user, from_date, end_date)
+
+            if reason == REASON_CHOICES.PUBLIC_HOLIDAYS:
+                return CustomResponse.bad_request(
+                    message=f"You have sent an invalid reason {reason}",
+                    error={
+                        "message": "This field should be one of the follwing reasons",
+                        "reasons": [
+                            reason
+                            for reason in REASON_CHOICES
+                            if reason != REASON_CHOICES.PUBLIC_HOLIDAYS
+                        ],
+                    },
+                )
+
+            curr_balance = getattr(user_reason_balance, reason)
+
+            pending_vacations = Vacation.objects.filter(
+                status=STATUS_CHOICES.PENDING,
+                applying_user=applying_user,
+                reason=reason,
+            ).values_list("actual_days", flat=True)
+
+            chcked_balance = curr_balance - sum(pending_vacations)
+
+            if curr_balance < vacation_days:
+                return CustomResponse.bad_request(
+                    message=f"The user have only {curr_balance} days left of reason '{reason.capitalize().replace('_', ' ')}'"
+                )
+
+            if chcked_balance < vacation_days:
+                return CustomResponse.bad_request(
+                    message=f"The user have an additional pending request that deducts {sum(pending_vacations)} days from your balance even though the current balance for the '{reason.capitalize().replace('_', ' ')}' category is only {curr_balance} days."
+                )
+
+            saved_vacation = Vacation.objects.create(
+                applying_user=applying_user,
+                type=TYPE_CHOICES.VACATIONS,
+                status=STATUS_CHOICES.PENDING,
+                reason=reason,
+                from_date=from_date,
+                end_date=end_date,
+                actual_days=vacation_days
+            )
+
+            message = f"You have successfully applied for a {reason.capitalize().replace('_', ' ')} vacation for {applying_user.full_name}."
+            if reason == REASON_CHOICES.ANNUAL_LEAVES or reason == REASON_CHOICES.EMERGENCY_LEAVE:
+                message = f"You have successfully applied for an {reason.capitalize().replace('_', ' ')} vacation for {applying_user.full_name}."
+
+            try:
+                ping_redis()
+            except:
+                return http_ensure_redis_error()
+
+            # set_notification_request_redis(serializer.data)
+            response_data: Dict = send_vacation_to_calendar(saved_vacation)
+
+            # Update the balance
+            balance = v.check_and_update_balance(
+                applying_user=saved_vacation.applying_user,
+                vacation=saved_vacation,
+                reason=saved_vacation.reason,
+                start_date=saved_vacation.from_date,
+                end_date=saved_vacation.end_date,
+            )
+
+            if balance is not True:
+                return CustomResponse.bad_request(message=balance)
+
+            # Approve the vacation.
+            saved_vacation.status = STATUS_CHOICES.APPROVED
+            saved_vacation.approval_user = admin
+            saved_vacation.save()
+
+            return CustomResponse.success(message=message, data=response_data)
+        return CustomResponse.bad_request(message="Please make sure that you entered a valid data.", error=serializer.errors)
\ No newline at end of file