Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Pre-Commit for CI checks #2961

Closed
korverdev opened this issue Jul 23, 2023 · 1 comment
Closed

Consider using Pre-Commit for CI checks #2961

korverdev opened this issue Jul 23, 2023 · 1 comment

Comments

@korverdev
Copy link
Contributor

Currently, for local checks, this project uses Pre-Commit with pinned versions of particular libraries. Most of the important checks are also confirmed server-side by GitHub actions. Breakage from a version update reported in #2960 goes over one of the core problems with this approach. Additionally, some Pre-Commit checks, albeit minor ones, aren't being confirmed server-side.

I'd like to drop the existing CI checks for individual quality checks in favor of running them all through Pre-Commit in a single action. This will allow for managing these versions through Pre-Commit in all cases. If this is a change this project is interested in making this change, I'd be happy to put together a PR for this.

@DimitriPapadopoulos
Copy link
Collaborator

See #2967 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants