-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant sort test #3359
Comments
Truth be told, I'm not really following what they're trying to say. Are we sure they were aware that Pre-Commit is enforced as a CI check? From what I can tell, there's really no need to have both. |
The Makefile distinguishes between Lines 13 to 21 in edef040
and sort-dictionaries implemented using pre-commit:Lines 27 to 28 in edef040
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I wanted to create an issue to discuss with the maintainers of this repo before I went ahead and deleted a test, but it appears this project is using both a Pre-Commit hook called
file-contents-sorter
and a test calledtest_dictionary_sorting()
to enforce dictionaries have been sorted.If I'm not missing anything, since
Pre-Commit
is enforced as a CI check before merge, thetest_dictionary_sorting()
test can be deleted. If that's accurate, I can get a PR in deleting the test.The text was updated successfully, but these errors were encountered: