Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: clicking outside of an editor should clear currentBlock (call dropPointer) even if selection was inside of editor before the click #2643

Open
VikhorKonstantin opened this issue Feb 29, 2024 · 2 comments · May be fixed by #2644
Open

Bug: clicking outside of an editor should clear currentBlock (call dropPointer) even if selection was inside of editor before the click #2643

VikhorKonstantin opened this issue Feb 29, 2024 · 2 comments · May be fixed by #2644
Labels
bug good first issue

Comments

@VikhorKonstantin
Copy link
Contributor

Describe a bug.

Steps to reproduce:

  1. Go to example_dev.html
  2. Click on somewhere outside of the editor
  3. Press '/'

Expected behavior:
Toolbox shouldn't be opened, because I've already went out of the editor by clicking outside

Actual:
Toolbox is still opened because we haven't cleared currentBlock

Device, Browser, OS:
Any

Editor.js version:
2.29.1
@neSpecc
Copy link
Member

neSpecc commented Feb 29, 2024

Seems like its works only on a second click. Need to debug this code in the ui.ts

image

@VikhorKonstantin VikhorKonstantin linked a pull request Feb 29, 2024 that will close this issue
Open
@VikhorKonstantin
Copy link
Contributor Author

Seems like its works only on a second click. Need to debug this code in the ui.ts

Seems like I found the issue, could you please check the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
2 participants
@neSpecc @VikhorKonstantin