-
Notifications
You must be signed in to change notification settings - Fork 28
OOM crash with too many files #218
Comments
Originally by @Ryuno-Ki. This is the directory structure of the storage that caused the crash:
|
Thanks, Hoshua, some notes here:
You must have done some magic since I tried the app last. |
I'd like to emphasize that my bug against Mozilla is still valid (PDF Viewer and file browser continue crashing). Just your app is fine :) |
@Ryuno-Ki: thanks for filing the bug. I will try to promote it so that it gets attention. It is great to hear that Firetext didn't crash. We have done a bit of performance work lately =) |
@joshua-s Would you and your team like to share some knowledge with Mozilla Hacks? As stated in the bugzilla bug, several apps suffer from getDeviceStorage(), so it would be helpful, to explain your approach. I can look after reaching out to Robert Nyman and point him to this issue. |
@Ryuno-Ki I don't actually know what is preventing us from crashing. Our IO code is certainly very messy. Our performance improvements have been moving from SVG icons to a font, encapsulating the editor in an If you would like to look, our IO enumerate function is here: https://github.com/codexa/firetext/blob/develop/scripts/io.js#L114 |
FYI bug #1104337 was linked today. |
If there are a large number of files in a storage, Firetext crashes with Out Of Memory.
We need to:
The text was updated successfully, but these errors were encountered: