Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement __reversed__() in Array #209

Closed
HarsheetKakar opened this issue Mar 24, 2020 · 5 comments · Fixed by #211
Closed

implement __reversed__() in Array #209

HarsheetKakar opened this issue Mar 24, 2020 · 5 comments · Fixed by #211
Labels
linear_data_structures

Comments

@HarsheetKakar
Copy link
Contributor

Description of the problem

currently reversed() returns a python list if OneDimensionalArray object is given, it should return ODA object.

Example of the problem

References/Other comments
@czgdp1807
Copy link
Member

Minor changes are needed, you can do it.

@HarsheetKakar
Copy link
Contributor Author

lets resolve #206 and I will bundle all the changes in one PR

@czgdp1807
Copy link
Member

#206 is a very different issue. Please make separate PR for this one.

@HarsheetKakar
Copy link
Contributor Author

small correction in the title above, it returns a reversed generator object.

@HarsheetKakar
Copy link
Contributor Author

I think i got confused with sorted and reversed, I am applying the changes in DODA, and not in ODA because it will work as it does with or without method overriding. Sorry for confusion

@HarsheetKakar HarsheetKakar mentioned this issue Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linear_data_structures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reversed method applied in DODA HarsheetKakar/pydatastructs
2 participants
@czgdp1807 @HarsheetKakar