Replace Node by TreeNode and GraphNode

[czgdp1807]

Description of the problem

Currently we have a generic Node class which basically has methods and data members for trees. However, when we will add graphs, the above Node class will not be compatible.
It would be better to use specific classes for, trees i.e., TreeNode(rename Node -> TreeNode) and a new GraphNode.
This issue aims at discussing the API for the latter.

Example of the problem

References/Other comments

[raajtilaksarma]

Can I take this issue? The current class Node in https://github.com/codezonediitj/pydatastructs/blob/master/pydatastructs/utils/misc_util.py is to be changed to TreeNode right?

[czgdp1807]

Yes. The other thing to be done is to discuss and finalise the API of GraphNode i.e., what data members and methods it should have. But we will do that later once Node is replaced by TreeNode across the modules.

[raajtilaksarma]

Okay. On it. Can you add the KWOC label to this issue?

[czgdp1807]

Let's discuss the API for GraphNode now. If you have anything suggest then please comment. Refer #17 and #13

[raajtilaksarma]

So next we need to create a class GraphNode right?

[czgdp1807]

Yes but before that we need to discuss its API.

[czgdp1807]

@raajtilaksarma Are you working on it?

[raajtilaksarma]

I will start tomorrow. Can you brief me on the API? By api do you mean properties of the GraphNode like its methods and variables?

…

On Sat, 7 Dec 2019, 10:06 pm Gagandeep Singh, ***@***.***> wrote: @raajtilaksarma <https://github.com/raajtilaksarma> Are you working on it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#34?email_source=notifications&email_token=AIJEPEAIIG7H7IECI27XAADQXPGJ3A5CNFSM4JOOJEF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGKQ3Y#issuecomment-562866287>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJEPEA5UVNNUUKGYOCRYM3QXPGJ3ANCNFSM4JOOJEFQ> .

[czgdp1807]

By api do you mean
properties of the GraphNode like its methods and variables?

Yes, especially user facing methods and variables. Refer the issue and PRs, links to which I have shared in other comment.
Once you suggest your ideas, we will improve on it.

[raajtilaksarma]

Cool will do so. I am checking out the wikipedia link of graphnode u shared.

…

On Sat, 7 Dec 2019, 10:27 pm Gagandeep Singh, ***@***.***> wrote: By api do you mean properties of the GraphNode like its methods and variables? Yes, especially user facing methods and variables. Refer the issue and PRs, links to which I have shared in other comment. Once you suggest your ideas, we will improve on it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#34?email_source=notifications&email_token=AIJEPEDEIPN6YWK6RKQOBNTQXPIV5A5CNFSM4JOOJEF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGK5JY#issuecomment-562867879>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJEPEC6YFWJCBSA7YRS4RTQXPIV5ANCNFSM4JOOJEFQ> .

[raajtilaksarma]

Should we have 2 classes for directed and undirected graph node? On Sat, 7 Dec 2019, 10:37 pm Raaj Tilak Sarma, <raajtilaksarma@gmail.com> wrote:

…

Cool will do so. I am checking out the wikipedia link of graphnode u shared. On Sat, 7 Dec 2019, 10:27 pm Gagandeep Singh, ***@***.***> wrote: > By api do you mean > properties of the GraphNode like its methods and variables? > > Yes, especially user facing methods and variables. Refer the issue and > PRs, links to which I have shared in other comment. > Once you suggest your ideas, we will improve on it. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#34?email_source=notifications&email_token=AIJEPEDEIPN6YWK6RKQOBNTQXPIV5A5CNFSM4JOOJEF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGK5JY#issuecomment-562867879>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AIJEPEC6YFWJCBSA7YRS4RTQXPIV5ANCNFSM4JOOJEFQ> > . >

[czgdp1807]

I don't think because both undirected and directed graph can be represented in terms of each other. For example if we use adjacency list or adjacency matrix then both can represent generic graphs.