pop_left and pop_right returns value #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=========================================
Coverage 98.019% 98.019%
=========================================
Files 20 20
Lines 1363 1363
=========================================
Hits 1336 1336
Misses 27 27 |
prshnt19
force-pushed
the
issue_124_pop_return_value
branch
from
b4e9761 to
3329c2b
Compare
|
Does this patch work for other types of linked lists? Can you update their tests as well? |
|
I have updated it for all the Linked lists. |
|
LGTM. @manaswinidas Any comments? |
manaswinidas
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs or Relevant literature
Fixes #124
Brief description of what is fixed or changed
Now pop_left and pop_right returns the popped node.
Updated tests to keep a check on whether the value is returned.
Other comments