-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added implementation for M-ary tree #140
Conversation
Added M_aryTreeNode for use in M_ary tree and an implementation for M_ary Tree. The work is in reference with issue codezonediitj#101.
Trailing white spaces can be removed by configuring your editor. For VSCode you may refer, https://marketplace.visualstudio.com/items?itemName=shardulm94.trailing-spaces |
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=============================================
- Coverage 98.179% 96.735% -1.445%
=============================================
Files 21 23 +2
Lines 1593 1746 +153
=============================================
+ Hits 1564 1689 +125
- Misses 29 57 +28
|
This PR doesn't need unit tests as they will be added when m-ary search trees will be added. |
Looks like we need some changes in the API of |
I don't see which files are causing the Travis to break. Can you please help out with this? |
Try running tests in vs code. It will tell you the file name and the line number which is having tab spaces in it. |
It's because tabs are being used for indentation. Please see the logs at https://travis-ci.org/github/codezonediitj/pydatastructs/builds/662786370?utm_source=github_status&utm_medium=notification |
It shows line number 69 in file test_code_quality.py. However, I have not edited and committed this file at all. |
If you suggest, I can reset my working branch with the pydatastructs/master and then push again after making necessary changes. It might sort out the issue. |
The problem is with the following line, E AssertionError: Tab present at MAryTreeNode, MAryTree
E in /home/czgdp1807ssd/codezonediitj/pydatastructs/pydatastructs/trees/__init__.py. Configure your editor to use white spaces. Acutally I didn't supply %(line, file_path). Therefore the problem wasn't visible. I am making a PR to fix it. Will restart the tests so that it's visible on Travis CI. |
Merging. Test coverage will reduce a bit. Adding |
@vibhu18116 |
Added M_aryTreeNode for use in M_ary tree and an implementation for
M_ary Tree. The work is in reference with issue #101.