Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured queue.py and stack.py #152

Merged
merged 15 commits into from
Mar 16, 2020

Conversation

HarsheetKakar
Copy link
Contributor

References to other Issues or PRs or Relevant literature

Fixes #150

Brief description of what is fixed or changed

  • changed front and rear to properties and changed the code accordingly.
  • using _check_type() instead of checking explicitly.

@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #152 into master will increase coverage by 0.145%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master      #152       +/-   ##
=============================================
+ Coverage   98.179%   98.325%   +0.145%     
=============================================
  Files           21        21               
  Lines         1593      1612       +19     
=============================================
+ Hits          1564      1585       +21     
+ Misses          29        27        -2
Impacted Files Coverage Δ
...datastructs/miscellaneous_data_structures/queue.py 100% <100%> (ø) ⬆️
...datastructs/miscellaneous_data_structures/stack.py 100% <100%> (+5.128%) ⬆️

Impacted file tree graph

@HarsheetKakar HarsheetKakar changed the title Restructured queue.py Restructured queue.py and stack.py Mar 14, 2020
@czgdp1807
Copy link
Member

Please add some tests for the lines marked red here. It will improve the diff coverage.

@HarsheetKakar
Copy link
Contributor Author

Please add some tests for the lines marked red here. It will improve the diff coverage.
I was wondering what it was 😆

@HarsheetKakar
Copy link
Contributor Author

@czgdp1807 can you go through it once more please? I have made the changes and LinkedListStack is on the way.

@HarsheetKakar
Copy link
Contributor Author

since we are already restructuring the codebase. kindly check #154 too @czgdp1807

@czgdp1807
Copy link
Member

Merging.

@czgdp1807 czgdp1807 merged commit 34a2eaf into codezonediitj:master Mar 16, 2020
@HarsheetKakar HarsheetKakar deleted the CodeRestructure branch March 16, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in Queue.
4 participants