Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for queue and stack updated #163

Merged
merged 11 commits into from
Mar 17, 2020
Merged

Conversation

HarsheetKakar
Copy link
Contributor

@HarsheetKakar HarsheetKakar commented Mar 16, 2020

References to other Issues or PRs or Relevant literature

Fixes #154

Brief description of what is fixed or changed

Other comments

please check if the changes in init.py are acceptable

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #163 into master will increase coverage by 0.003%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #163       +/-   ##
=============================================
+ Coverage   98.325%   98.328%   +0.003%     
=============================================
  Files           21        21               
  Lines         1612      1615        +3     
=============================================
+ Hits          1585      1588        +3     
  Misses          27        27               
Impacted Files Coverage Δ
...datastructs/miscellaneous_data_structures/stack.py 100.000% <100.000%> (ø)

Impacted file tree graph

@HarsheetKakar HarsheetKakar changed the title test_queue.py updated Tests for queue and stack updated Mar 16, 2020
@HarsheetKakar HarsheetKakar marked this pull request as ready for review March 16, 2020 15:03
@czgdp1807
Copy link
Member

Test both the implementations but use the interface classes Queue and Stack to test. Implementation classes shouldn't be accessed.

@HarsheetKakar HarsheetKakar requested a review from czgdp1807 March 16, 2020 17:03
@czgdp1807 czgdp1807 merged commit fbbd987 into codezonediitj:master Mar 17, 2020
@HarsheetKakar HarsheetKakar deleted the Test branch March 17, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple tests written under single test name.
3 participants