-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unnecessary aliasing of OneDimensionalArray #161 #165
Conversation
please review the pull request and do the needfull |
The tests are failing because there are multiple files where this aliasing was used. Places where |
all places where ODA is written should be interchanged to OneDimensionalArray,right ? |
I interchanged it,but when I runed it, I got a errors like |
I changed it and commited again,but the fail is not going |
@@ -48,8 +48,8 @@ class OneDimensionalArray(Array): | |||
Examples | |||
======== | |||
|
|||
>>> from pydatastructs import OneDimensionalArray as ODA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe doctest is failing because u removed the import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be restored.
remove trailing whitespaces and make changes in test_array.py |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=============================================
+ Coverage 98.328% 98.410% +0.082%
=============================================
Files 21 22 +1
Lines 1615 1699 +84
=============================================
+ Hits 1588 1672 +84
Misses 27 27
|
Thanks. |
References to other Issues or PRs or Relevant literature
Fixes #161
Brief description of what is fixed or changed
Other comments