New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing all type() to _check_type() #197

Merged

czgdp1807 merged 3 commits into codezonediitj:master from din1881:code_quality

Mar 22, 2020

Contributor

din1881 commented Mar 22, 2020 •

edited by czgdp1807

Loading

Fixes #183


          Changing all type() to _check_type()

6b0fd81

czgdp1807 reviewed

View reviewed changes

pydatastructs/linear_data_structures/arrays.py Outdated Show resolved Hide resolved

czgdp1807 reviewed

View reviewed changes

pydatastructs/linear_data_structures/arrays.py Outdated Show resolved Hide resolved

czgdp1807 reviewed

View reviewed changes

pydatastructs/linear_data_structures/arrays.py Outdated Show resolved Hide resolved

czgdp1807 reviewed

View reviewed changes

pydatastructs/linear_data_structures/arrays.py Outdated Show resolved Hide resolved


          Apply suggestions from code review

8dbb420

czgdp1807 added code_quality easy enhancement labels

czgdp1807 reviewed

View reviewed changes

pydatastructs/linear_data_structures/arrays.py Outdated Show resolved Hide resolved

czgdp1807 reviewed

View reviewed changes

pydatastructs/linear_data_structures/arrays.py Outdated Show resolved Hide resolved

czgdp1807 reviewed

View reviewed changes

pydatastructs/linear_data_structures/arrays.py Outdated Show resolved Hide resolved

czgdp1807 reviewed

View reviewed changes

pydatastructs/linear_data_structures/arrays.py Outdated Show resolved Hide resolved


          Apply suggestions from code review

cd578a0

codecov bot commented Mar 22, 2020

Codecov Report

Merging #197 into master will not change coverage by %.
The diff coverage is 100.000%.

@@            Coverage Diff            @@
##            master      #197   +/-   ##
=========================================
  Coverage   96.933%   96.933%           
=========================================
  Files           24        24           
  Lines         1859      1859           
=========================================
  Hits          1802      1802           
  Misses          57        57

Impacted Files	Coverage Δ
pydatastructs/linear_data_structures/arrays.py	`100.000% <100.000%> (ø)`

Member

czgdp1807 commented Mar 22, 2020

Hi @din1881
Thanks for the PR. There were trivial mistakes in your initial commit. I have corrected them in the suggestions and applied those to your branch.
Please make sure from the next PR onwards, to not clear the PR template instead fill it.

czgdp1807 merged commit fcb27e6 into codezonediitj:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code_quality enhancement