Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased code coverage #95

Merged
merged 33 commits into from
Mar 2, 2020
Merged

Increased code coverage #95

merged 33 commits into from
Mar 2, 2020

Conversation

iamrajiv
Copy link
Contributor

@iamrajiv iamrajiv commented Feb 23, 2020

References to other Issues or PRs or Relevant literature

Fixes #19

Brief description of what is fixed or changed

Improved tests in order to increase PyDataStructs code coverage

Other comments

@codecov
Copy link

codecov bot commented Feb 23, 2020

Codecov Report

Merging #95 into master will increase coverage by 0.526%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##            master       #95       +/-   ##
=============================================
+ Coverage   97.273%   97.799%   +0.526%     
=============================================
  Files           32        20       -12     
  Lines         1797      1227      -570     
=============================================
- Hits          1748      1200      -548     
+ Misses          49        27       -22
Impacted Files Coverage Δ
pydatastructs/graphs/__init__.py 100% <ø> (ø) ⬆️
...tructs/trees/tests/test_space_partitioning_tree.py
pydatastructs/utils/tests/test_misc_util.py
.../miscellaneous_data_structures/tests/test_queue.py
...ydatastructs/graphs/tests/test_adjacency_matrix.py
pydatastructs/graphs/tests/test_adjacency_list.py
pydatastructs/trees/tests/test_binary_trees.py
...neous_data_structures/tests/test_binomial_trees.py
.../linear_data_structures/tests/test_linked_lists.py
...tructs/linear_data_structures/tests/test_arrays.py
... and 8 more

Impacted file tree graph

@czgdp1807
Copy link
Member

Are you participating through GSSoC, 2020?

@iamrajiv
Copy link
Contributor Author

@czgdp1807 Yes

@iamrajiv iamrajiv changed the title increased code coverage [WIP] increased code coverage Feb 23, 2020
@czgdp1807 czgdp1807 added easy and removed beginner labels Feb 23, 2020
@czgdp1807
Copy link
Member

If you observe any differences in the observed output and the expected output then please open a separate issue.

.coveragerc Outdated Show resolved Hide resolved
@czgdp1807
Copy link
Member

Delete the system generated files.

@iamrajiv iamrajiv requested a review from czgdp1807 February 25, 2020 09:41
Copy link
Member

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update .gitignore with the following,

# Compiled source #
###################
*.com
*.class
*.dll
*.exe
*.o
*.so
*.gch

# Packages #
############
# it's better to unpack these files and commit the raw source
# git has its own built in compression methods
*.7z
*.dmg
*.gz
*.iso
*.jar
*.rar
*.tar
*.zip

# Logs and databases #
######################
*.log
*.sql
*.sqlite

# OS generated files #
######################
.DS_Store
.DS_Store?
._*
.Spotlight-V100
.Trashes
ehthumbs.db
Thumbs.db

# Python Files #
################
*.pyc
*.pyo
*~
__pycache__/

# Backup Files #
################
*.bak
*.swp

# Editor Files #
################
.vscode/
.vs/

It will be merged on 2nd March if tests are passing. Thanks.

.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@czgdp1807
Copy link
Member

Please delete the DS_Store binary file.

@czgdp1807
Copy link
Member

czgdp1807 commented Mar 2, 2020

Looks ready to go. ping @codezonediitj/gssoc2020 Any comments?

@manaswinidas
Copy link
Contributor

Looks ready to go. ping @codezonediitj/gssoc2020 Any comments?

LGTM too.

@czgdp1807 czgdp1807 merged commit 2d702b7 into codezonediitj:master Mar 2, 2020
@iamrajiv iamrajiv changed the title [WIP] increased code coverage increased code coverage Mar 2, 2020
@iamrajiv iamrajiv deleted the track_coverage_#19 branch March 2, 2020 14:37
@iamrajiv iamrajiv changed the title increased code coverage Increased code coverage Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track coverage
3 participants