fix: creating promise for every delayed saving to await #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farenheith
force-pushed
the
fix-saving-delay-semaphore-bug
branch
from
92c9242 to
3dd7d6b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
codibrebot
pushed a commit
that referenced
this pull request
Jun 17, 2023
## [1.8.3](v1.8.2...v1.8.3) (2023-06-17) ### Bug Fixes * creating promise for every delayed saving to await ([#30](#30)) ([9115034](9115034))
|
🎉 This PR is included in version 1.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first algorithm, there could be calls to be accumulated in the same saving moment, bug with no savingPromise defined yet to await, making them susceptible to be ended after the semaphore release. With this change. the awaitPromise is generated synchronously just after the first request to be accumulated is received, so, every accumulating promise will start to await for it too to complete.
I'll figure out later how to write a test that checks this specific error case