fix: bettering lint and avoiding floating promises #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Farenheith
commented
Jun 17, 2023
| entries: new Map([[redisKey, [realTtl, resultCopy]]]), | ||
| }, | ||
| redisKey.replace(/:/g, '/'), | ||
| ); |
There was a problem hiding this comment.
This points allow us to keep the s3 file with the same name of the redis key if there is no maxSavingDelay, for a better refarencing
codibrebot
pushed a commit
that referenced
this pull request
Jun 17, 2023
## [1.8.4](v1.8.3...v1.8.4) (2023-06-17) ### Bug Fixes * bettering lint and avoiding floating promises ([#31](#31)) ([cd0577c](cd0577c))
|
🎉 This PR is included in version 1.8.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some floating promises could make semaphores to be released before the work as done. We bettered lint and fixed the weak spots to prevent it from happening