Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 feature add youtube view #35

Merged
merged 4 commits into from
May 31, 2021
Merged

33 feature add youtube view #35

merged 4 commits into from
May 31, 2021

Conversation

deep-diver
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #35 (f62fe03) into main (37626f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   42.85%   42.85%           
=======================================
  Files           2        2           
  Lines           7        7           
=======================================
  Hits            3        3           
  Misses          3        3           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37626f7...f62fe03. Read the comment docs.

@kkweon
Copy link
Member

kkweon commented May 30, 2021

Update minsdkversion

minSdkVersion 16

lets use 20

client/lib/test-server.dart Outdated Show resolved Hide resolved
client/lib/main.dart Outdated Show resolved Hide resolved
@deep-diver
Copy link
Member Author

@kkweon please review this PR again

Copy link
Member

@kkweon kkweon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

client/lib/detail.dart Show resolved Hide resolved
@kkweon kkweon merged commit d1e26c0 into main May 31, 2021
@kkweon kkweon deleted the 33-feature-add-youtube-view branch May 31, 2021 17:24
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants