Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the message factory architecture #37

Closed
ForNeVeR opened this issue Jul 2, 2019 · 0 comments · Fixed by #39
Closed

Clear the message factory architecture #37

ForNeVeR opened this issue Jul 2, 2019 · 0 comments · Fixed by #39
Assignees
@ForNeVeR
Labels
kind:refactor

Comments

@ForNeVeR
Copy link
Member

ForNeVeR commented Jul 2, 2019

Currently we have this mess:

emulsion/Emulsion/Program.fs

Line 48 in eb05ad0

telegramFactory = fun factory _ name -> Telegram.spawn telegram factory name } // TODO[F]: Change the architecture here so we don't need to ignore the `core` parameter.

We'll need to clean it up (i.e. remote the need to ignore the argument) after we migrate XMPP to the new architecture. Depends on completion of #29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForNeVeR ForNeVeR

Labels
kind:refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IMessageSystem implementation for XMPP codingteam/emulsion
1 participant
@ForNeVeR