Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message system implementation for Telegram #34

Merged
merged 7 commits into from
Jul 2, 2019
Merged

Message system implementation for Telegram #34

merged 7 commits into from
Jul 2, 2019

Conversation

ForNeVeR
Copy link
Member

@ForNeVeR ForNeVeR commented Jun 15, 2019 •
edited
Loading

First part of #29.

After merge

  • File an issue about properly terminating the application (manage the root cancellation token there)
  • Resolve all the comments that require filling additional issues

@ForNeVeR ForNeVeR self-assigned this Jun 15, 2019
ForNeVeR
ForNeVeR commented Jun 15, 2019
View reviewed changes
Emulsion/MessageSender.fs Outdated Show resolved Hide resolved
Emulsion/Program.fs Show resolved Hide resolved
Emulsion/Program.fs Show resolved Hide resolved
Emulsion/Telegram/Funogram.fs Show resolved Hide resolved
@ForNeVeR ForNeVeR requested a review from gsomix June 15, 2019 16:50
@ForNeVeR ForNeVeR marked this pull request as ready for review June 15, 2019 16:50
gsomix
gsomix approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@gsomix gsomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForNeVeR
Copy link
Member Author

ForNeVeR commented Jul 2, 2019

Thanks for the review!

@ForNeVeR ForNeVeR merged commit eb05ad0 into master Jul 2, 2019
@ForNeVeR ForNeVeR deleted the feature/29-queue branch July 2, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsomix gsomix gsomix approved these changes

Assignees

@ForNeVeR ForNeVeR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForNeVeR @gsomix