-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated layout #1212
base: develop
Are you sure you want to change the base?
updated layout #1212
Conversation
Added a main div and fixed classname so footer stays to the bottom
@Zaid-B24 is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/(app)/layout.tsx (1)
81-91
: LGTM! The layout implementation effectively addresses the requirements.The grid-based layout with
grid-rows-[auto_1fr_auto]
is an excellent choice for ensuring the footer sticks to the bottom while maintaining a flexible content area. The main wrapper's constraints provide good content width control and proper dark mode support.Consider adding padding to the main wrapper for better content spacing:
- <main className="w-full relative mx-auto max-w-2xl bg-neutral-100 dark:bg-black sm:mx-auto"> + <main className="w-full relative mx-auto max-w-2xl bg-neutral-100 dark:bg-black sm:mx-auto px-4 py-6">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
app/(app)/layout.tsx
(1 hunks)app/(app)/my-posts/_client.tsx
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- app/(app)/my-posts/_client.tsx
…o bottom of screen
@CarolinaCobo I used flex flex-col min-h-screen, to stick the footer to bottom, can you please review it .? |
@Zaid-B24 looks good! There are some prettier errors now, could you run |
Ran prettier fix on the layout file
Ran prettier fix on the _client.tsx file
4e0efaa
to
14fd90a
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will test the changes everywhere. |
✨ Codu Pull Request 💻
Fixes #(1171)
Pull Request details
Any Breaking changes
Associated Screenshots
[Optional] What gif best describes this PR or how it makes you feel