chore: added all selected columns to the groupBy function #1054
Conversation
|
@JohnAllenTech is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes in the pull request focus on enhancing the post management system within the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
JohnAllenTech
force-pushed
the
fix/broken-article-query
branch
from
3dd0af0 to
909133c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| .groupBy( | ||
| post.id, | ||
| post.slug, | ||
| post.title, | ||
| post.excerpt, | ||
| post.published, | ||
| post.readTimeMins, | ||
| post.likes, | ||
| bookmarked.id, | ||
| user.id, | ||
| ) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid grouping by all selected columns; consider query refactoring
Including all selected columns in the groupBy clause may lead to performance issues and isn't always necessary. This approach can cause inefficient queries and might not return the desired results. Since the joins with post_tag and tag tables may introduce duplicate posts due to posts having multiple tags, consider using DISTINCT to retrieve unique posts or refactoring the query to eliminate duplicates without grouping.
Apply this diff to use distinct instead of groupBy:
.where(
and(
isNotNull(post.published),
lte(post.published, new Date().toISOString()),
tagFilter ? eq(tag.title, tagFilter.toUpperCase()) : undefined,
cursor ? paginationMapping[sort].cursor : undefined,
),
)
+ .distinctOn([post.id])
- .groupBy(
- post.id,
- post.slug,
- post.title,
- post.excerpt,
- post.published,
- post.readTimeMins,
- post.likes,
- bookmarked.id,
- user.id,
- )
.limit(limit + 1)
.orderBy(paginationMapping[sort].orderBy);Alternatively, you can restructure the query to fetch tags separately or use aggregate functions if necessary.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .groupBy( | |
| post.id, | |
| post.slug, | |
| post.title, | |
| post.excerpt, | |
| post.published, | |
| post.readTimeMins, | |
| post.likes, | |
| bookmarked.id, | |
| user.id, | |
| ) | |
| .where( | |
| and( | |
| isNotNull(post.published), | |
| lte(post.published, new Date().toISOString()), | |
| tagFilter ? eq(tag.title, tagFilter.toUpperCase()) : undefined, | |
| cursor ? paginationMapping[sort].cursor : undefined, | |
| ), | |
| ) | |
| .distinctOn([post.id]) | |
| .limit(limit + 1) | |
| .orderBy(paginationMapping[sort].orderBy); |
|
Should we bump drizzle to the latest version to see what it breaks in this too (that's coming in a PR anyway 😂 ) |
Will do |
|
@NiallJoeMaher bumped the dependency and everything is still working. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✨ Codu Pull Request 💻
Fixes #1053
Pull Request details
Seems like a new thing in drizzle? Didnt try to revert versions just fixed it in place.
Any Breaking changes
Associated Screenshots